Fixes the policy to choose the notifications for popups.

ui/message_center/notification_list_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/message_center/notification_list.h"
 
 #include "base/basictypes.h"
 #include "base/i18n/time_formatting.h"
 #include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
@@ skipping 194 matching lines @@
   notification_list()->AddNotification(
       ui::notifications::NOTIFICATION_TYPE_SIMPLE, "id3", UTF8ToUTF16("title1"),
       UTF8ToUTF16("message1"), UTF8ToUTF16("source2"), "ext1", NULL);
 
   notification_list()->SendRemoveNotificationsBySource("id0");
   EXPECT_EQ(2u, delegate()->GetSendRemoveCountAndReset());
   notification_list()->SendRemoveNotificationsByExtension("id0");
   EXPECT_EQ(3u, delegate()->GetSendRemoveCountAndReset());
 }
 
+TEST_F(NotificationListTest, OldPopupShouldNotBeHidden) {
+  std::vector<std::string> ids;
+  for (size_t i = 0; i <= NotificationList::kMaxVisiblePopupNotifications;
+       i++) {
+    ids.push_back(AddNotification(NULL));
+  }
+
+  NotificationList::Notifications popups;
+  notification_list()->GetPopupNotifications(&popups);
+  // The popup should contain the oldest kMaxVisiblePopupNotifications. Newer
+  // one should come earlier in the popup list. It means, the last element
+  // of |popups| should be the firstly added one, and so on.
+  EXPECT_EQ(NotificationList::kMaxVisiblePopupNotifications, popups.size());
+  NotificationList::Notifications::const_reverse_iterator iter =
+      popups.rbegin();
+  for (size_t i = 0; i < NotificationList::kMaxVisiblePopupNotifications;
+       ++i, ++iter) {
+    EXPECT_EQ(ids[i], iter->id) << i;
+  }
+
+  notification_list()->MarkPopupsAsShown(ui::notifications::DEFAULT_PRIORITY);
+  popups.clear();
+  notification_list()->GetPopupNotifications(&popups);
+  EXPECT_EQ(1u, popups.size());
+  EXPECT_EQ(ids[ids.size() - 1], popups.begin()->id);
+}
+
 TEST_F(NotificationListTest, Priority) {
   ASSERT_EQ(0u, notification_list()->NotificationCount());
   ASSERT_EQ(0u, notification_list()->unread_count());
 
   // Default priority has the limit on the number of the popups.
   for (size_t i = 0; i <= NotificationList::kMaxVisiblePopupNotifications;
        ++i) {
     AddNotification(NULL);
   }
   EXPECT_EQ(NotificationList::kMaxVisiblePopupNotifications + 1,
@@ skipping 105 matching lines @@
 
   notification_list()->SetQuietMode(false);
   AddNotification(NULL);
   EXPECT_EQ(4u, notification_list()->NotificationCount());
   EXPECT_EQ(1u, GetPopupCounts());
 
   // TODO(mukai): Add test of quiet mode with expiration.
 }
 
 }  // namespace message_center