media/filters/gpu_video_decoder.h - Issue 11826064: Enforce non-negative BitstreamBuffer id

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/gpu_video_decoder.h

Issue 11826064: Enforce non-negative BitstreamBuffer id (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Documented the wrapping at 30 bits. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/filters/gpu_video_decoder.h

diff --git a/media/filters/gpu_video_decoder.h b/media/filters/gpu_video_decoder.h

index ae51189af890b75d976813e125a8c0f64c8ee209..b7f2632da21e383520a97a02444c93a79ab0b65d 100644

--- a/media/filters/gpu_video_decoder.h

+++ b/media/filters/gpu_video_decoder.h

@@ -218,8 +218,8 @@ class MEDIA_EXPORT GpuVideoDecoder

// picture_buffer_id and the frame wrapping the corresponding Picture, for

// frames that have been decoded but haven't been requested by a Read() yet.

std::list<scoped_refptr<VideoFrame> > ready_video_frames_;

- int64 next_picture_buffer_id_;

- int64 next_bitstream_buffer_id_;

+ int32 next_picture_buffer_id_;

+ int32 next_bitstream_buffer_id_;

// Indicates decoding error occurred.

bool error_occured_;