content/common/gpu/media/video_decode_accelerator_unittest.cc - Issue 11826064: Enforce non-negative BitstreamBuffer id

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/video_decode_accelerator_unittest.cc

Issue 11826064: Enforce non-negative BitstreamBuffer id (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Documented the wrapping at 30 bits. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/gpu/media/video_decode_accelerator_unittest.cc

diff --git a/content/common/gpu/media/video_decode_accelerator_unittest.cc b/content/common/gpu/media/video_decode_accelerator_unittest.cc

index f325b40c8fcd317f72648a9fc05fdf9285775246..99e6a4459b5113edb4a08537cbc93be340beaa92 100644

--- a/content/common/gpu/media/video_decode_accelerator_unittest.cc

+++ b/content/common/gpu/media/video_decode_accelerator_unittest.cc

@@ -603,7 +603,9 @@ void GLRenderingVDAClient::DecodeNextFragments() {

base::SharedMemoryHandle dup_handle;

CHECK(shm.ShareToProcess(base::Process::Current().handle(), &dup_handle));

media::BitstreamBuffer bitstream_buffer(

- next_bitstream_buffer_id_++, dup_handle, next_fragment_size);

+ next_bitstream_buffer_id_, dup_handle, next_fragment_size);

+ // Mask against 30 bits, to avoid (undefined) wraparound on signed integer.

+ next_bitstream_buffer_id_ = (next_bitstream_buffer_id_ + 1) & 0x3FFFFFFF;

decoder_->Decode(bitstream_buffer);

++outstanding_decodes_;

encoded_data_next_pos_to_decode_ = end_pos;