Issue 11824063: Separate MEGAMORPHIC and GENERIC ic states

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11824063: Separate MEGAMORPHIC and GENERIC ic states (Closed)

Created:
7 years, 11 months ago by Toon Verwaest

Modified:
7 years, 11 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Separate MEGAMORPHIC and GENERIC ic states Committed: https://code.google.com/p/v8/source/detail?r=13402

Patch Set 1 #

Patch Set 2 : Move GENERIC from || to ASSERT(! #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -25 lines)			Patch
M	src/builtins.h	View		3 chunks	+9 lines, -9 lines	0 comments	Download
M	src/ic.h	View		3 chunks	+0 lines, -11 lines	0 comments	Download
M	src/ic.cc	View	1	13 chunks	+14 lines, -3 lines	0 comments	Download
M	src/objects.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/objects-visiting-inl.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/type-info.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/v8globals.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

7 years, 11 months ago (2013-01-16 16:49:51 UTC) #3

Message was sent while issue was closed.

On 2013/01/16 14:58:58, ulan wrote:
> LGTM

I ran across a ton of crashes with this:

STDERR: #
STDERR: # Fatal error in ../../v8/src/ic.cc, line 1350
STDERR: # unreachable code
STDERR: #

When I was testing webkit layout tests on debug built chromium with bleeding
edge V8. I think this might be the culprit...

Expand Messages | Collapse Messages