src/type-info.cc - Issue 11824063: Separate MEGAMORPHIC and GENERIC ic states

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/type-info.cc

Issue 11824063: Separate MEGAMORPHIC and GENERIC ic states (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Move GENERIC from || to ASSERT(! Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/type-info.cc

diff --git a/src/type-info.cc b/src/type-info.cc

index 00e8ee85f7c139fb826115e6848083c70128af9d..75e915bb846d9b0e8c57f8c29102c2c7526c939f 100644

--- a/src/type-info.cc

+++ b/src/type-info.cc

@@ -488,7 +488,7 @@ void TypeFeedbackOracle::CollectReceiverTypes(TypeFeedbackId ast_id,

isolate_->builtins()->builtin(Builtins::kStoreIC_GlobalProxy)) {

// TODO(fschneider): We could collect the maps and signal that

// we need a generic store (or load) here.

- ASSERT(Handle<Code>::cast(object)->ic_state() == MEGAMORPHIC);

+ ASSERT(Handle<Code>::cast(object)->ic_state() == GENERIC);

} else if (object->IsMap()) {

types->Add(Handle<Map>::cast(object), zone());

} else if (FLAG_collect_megamorphic_maps_from_stub_cache &&

« no previous file with comments | « src/objects-visiting-inl.h ('k') | src/v8globals.h » ('j') | no next file with comments »