Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1944)

Issue 11821036: Fixes couple of bugs in the TabStrip that could cause tabs to dance (Closed)

Created:
7 years, 11 months ago by sky
Modified:
7 years, 11 months ago
CC:
chromium-reviews, tfarina, dcheng
Visibility:
Public.

Description

Fixes couple of bugs in the TabStrip that could cause tabs to dance around. Both only occurred when the active tab width differs from inactive tab width (lots-o-tabs). . ResizeLayoutTabs() had an optimization that avoided doing anything if the width of the first tab hasn't changed. Problems is if the first tab is active and inactive tabs have a smaller width than active tabs than the width won't have changed but we still need to layout. I removed the optimization. . If selecting a tab triggers a bounds change the coordinates used by tab dragging would be wrong (because they extract them from the event, which is in the original coordinates). . Needed to tweak rtl code. BUG=140747 TEST=see bug, but make sure no weird behavior with tab selection/dragging on windows/chrome-os. R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175991

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -20 lines) Patch
M chrome/browser/ui/views/tabs/tab.cc View 3 chunks +14 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.h View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 2 chunks +6 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
7 years, 11 months ago (2013-01-09 22:18:19 UTC) #1
Ben Goodger (Google)
lgtm
7 years, 11 months ago (2013-01-09 23:44:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/11821036/1
7 years, 11 months ago (2013-01-10 00:01:03 UTC) #3
commit-bot: I haz the power
7 years, 11 months ago (2013-01-10 02:21:06 UTC) #4
Message was sent while issue was closed.
Change committed as 175991

Powered by Google App Engine
This is Rietveld 408576698