Chrome-side implementation of AutocompleteErrorEvent#reason.

Chrome-side implementation of AutocompleteErrorEvent#reason.

BUG=168967
R=isherman@chromium.org,tsepez@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176484

[Dan Beam, 2013-01-09 07:03:02]

I'll clean up the description of the CL when I'm not so tired...

[Ilya Sherman, 2013-01-09 08:54:38]

https://codereview.chromium.org/11821020/diff/1/chrome/browser/autofill/autof...
File chrome/browser/autofill/autofill_manager.h (right):

https://codereview.chromium.org/11821020/diff/1/chrome/browser/autofill/autof...
chrome/browser/autofill/autofill_manager.h:177: const FormData& form_data);
Hmm, why not pass an error with a reason, or a success with form data?  Is it
possible to have multiple types of success?

[Dan Beam, 2013-01-09 18:37:38]

https://codereview.chromium.org/11821020/diff/1/chrome/browser/autofill/autof...
File chrome/browser/autofill/autofill_manager.h (right):

https://codereview.chromium.org/11821020/diff/1/chrome/browser/autofill/autof...
chrome/browser/autofill/autofill_manager.h:177: const FormData& form_data);
On 2013/01/09 08:54:39, Ilya Sherman wrote:
> Hmm, why not pass an error with a reason, or a success with form data?  Is it
> possible to have multiple types of success?

Because I didn't like that I ended up with am error method which checked if the
result is a success (seemed odd). This also saves a bit of redundant code.

[Ilya Sherman, 2013-01-10 01:49:13]

LGTM

[Dan Beam, 2013-01-10 04:59:43]

TBR'ing tsepez@ for IPC (as it's just shuffling and removing)

[Dan Beam, 2013-01-10 05:35:30]

oh, I should mention this is blocked on
https://bugs.webkit.org/show_bug.cgi?id=105568 landing and being rolled into
chrome :(

[Tom Sepez, 2013-01-10 18:09:11]

Messages LGTM.

[commit-bot: I haz the power, 2013-01-11 20:22:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/11821020/11001

[Dan Beam, 2013-01-11 20:53:21]

isherman@: I had to update the unit tests, can you take another look?  Also, I
guess I should maybe write tests for the cancel case now as well?

[commit-bot: I haz the power, 2013-01-11 20:55:20]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_clang_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[Ilya Sherman, 2013-01-11 20:59:56]

Test changes look ok

https://codereview.chromium.org/11821020/diff/29001/chrome/browser/autofill/a...
File chrome/browser/autofill/autofill_manager_unittest.cc (right):

https://codereview.chromium.org/11821020/diff/29001/chrome/browser/autofill/a...
chrome/browser/autofill/autofill_manager_unittest.cc:475:
std::vector<std::pair<WebKit::WebFormElement::AutocompleteResult, FormData> >&
nit: Maybe use "using WebKit::WebFormElement" or add a typedef to make this
wrapping less awful?

[Dan Beam, 2013-01-11 21:50:14]

https://codereview.chromium.org/11821020/diff/29001/chrome/browser/autofill/a...
File chrome/browser/autofill/autofill_manager_unittest.cc (right):

https://codereview.chromium.org/11821020/diff/29001/chrome/browser/autofill/a...
chrome/browser/autofill/autofill_manager_unittest.cc:475:
std::vector<std::pair<WebKit::WebFormElement::AutocompleteResult, FormData> >&
On 2013/01/11 20:59:56, Ilya Sherman wrote:
> nit: Maybe use "using WebKit::WebFormElement" or add a typedef to make this
> wrapping less awful?

Done.

[commit-bot: I haz the power, 2013-01-11 21:57:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/11821020/31002

[commit-bot: I haz the power, 2013-01-12 00:04:01]

Retried try job too often on linux_rel for step(s) browser_tests