Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 11821013: MIPS: Optimise Math.floor(x/y) to use integer division for MIPS. (Closed)

Created:
7 years, 11 months ago by palfia
Modified:
7 years, 6 months ago
Reviewers:
kisg, Paul Lind, danno
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Optimise Math.floor(x/y) to use integer division for MIPS. Use div instruction if some divisors do not have magic number. Based on commit r11427 (318a9598). BUG= TEST=

Patch Set 1 #

Patch Set 2 : Fix ASSERT #

Total comments: 2

Patch Set 3 : Fixed mjsunit test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -5 lines) Patch
M src/hydrogen-instructions.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M src/mips/lithium-codegen-mips.h View 1 chunk +11 lines, -0 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 2 chunks +133 lines, -0 lines 0 comments Download
M src/mips/lithium-mips.h View 3 chunks +24 lines, -0 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +62 lines, -2 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
palfia
Please merge the following CL first to avoid merge conflicts: https://chromiumcodereview.appspot.com/11783049
7 years, 11 months ago (2013-01-09 02:02:24 UTC) #1
danno
https://codereview.chromium.org/11821013/diff/3001/test/mjsunit/math-floor-of-div.js File test/mjsunit/math-floor-of-div.js (right): https://codereview.chromium.org/11821013/diff/3001/test/mjsunit/math-floor-of-div.js#newcode98 test/mjsunit/math-floor-of-div.js:98: assertEquals(Math.floor(div(k, 13)), Math.floor(k / 13)); Why this change?
7 years, 10 months ago (2013-02-11 15:30:49 UTC) #2
palfia
Thanks for the review! Sorry, I forgot about this CL somehow. I've uploaded a new ...
7 years, 7 months ago (2013-05-09 22:50:09 UTC) #3
palfia
7 years, 6 months ago (2013-06-17 15:10:56 UTC) #4
Closing issue, submitted in: https://codereview.chromium.org/16951016/

Powered by Google App Engine
This is Rietveld 408576698