Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 11783049: MIPS: Emit madd.d for multiply-add on MIPS. (Closed)

Created:
7 years, 11 months ago by palfia
Modified:
7 years, 11 months ago
Reviewers:
kisg, Paul Lind, Yang, danno
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Emit madd.d for multiply-add on MIPS. Based on commit r12958 (04586adf). BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=13342

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -2 lines) Patch
src/mips/assembler-mips.h View 2 chunks +8 lines, -0 lines 0 comments Download
src/mips/assembler-mips.cc View 2 chunks +20 lines, -0 lines 0 comments Download
src/mips/constants-mips.h View 4 chunks +11 lines, -1 line 0 comments Download
src/mips/constants-mips.cc View 1 chunk +2 lines, -0 lines 0 comments Download
src/mips/disasm-mips.cc View 2 chunks +13 lines, -0 lines 0 comments Download
src/mips/lithium-codegen-mips.cc View 1 chunk +12 lines, -0 lines 0 comments Download
src/mips/lithium-mips.h View 3 chunks +21 lines, -0 lines 0 comments Download
src/mips/lithium-mips.cc View 3 chunks +33 lines, -1 line 0 comments Download
src/mips/simulator-mips.cc View 3 chunks +16 lines, -0 lines 0 comments Download
test/cctest/test-assembler-mips.cc View 4 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
palfia
7 years, 11 months ago (2013-01-09 02:02:18 UTC) #1
danno
Yang, could you please take over the review of this CL and land it for ...
7 years, 11 months ago (2013-01-09 07:50:52 UTC) #2
Yang
On 2013/01/09 07:50:52, danno wrote: > Yang, could you please take over the review of ...
7 years, 11 months ago (2013-01-09 12:31:06 UTC) #3
hans
On 2013/01/09 12:31:06, Yang wrote: > Remark for the future not really related to this ...
7 years, 11 months ago (2013-01-09 15:13:08 UTC) #4
Yang
7 years, 11 months ago (2013-01-09 15:15:35 UTC) #5
Message was sent while issue was closed.
On 2013/01/09 15:13:08, hans wrote:
> On 2013/01/09 12:31:06, Yang wrote:
> > Remark for the future not really related to this CL: both multiply-add and
> > floor-of-div essentially do the same thing. The former is implemented in
> > Lithium, the latter in Hydrogen. Both have their merits, but maybe we should
> > consistently consider choosing one over the other.
> 
> For reference, here is the comment where Jakob suggested I'd do multiply-add
> during Lithium formation:
https://chromiumcodereview.appspot.com/11293061/#msg5
> 
> If we want to be consistent here, I could look into switching over the
> floor-of-div code as a clean-up.

That would be a good solution. Then again, I think we can consider that with low
priority.

Powered by Google App Engine
This is Rietveld 408576698