Remove profile-keyed factory boilerplates.

Remove profile-keyed factory boilerplates for bookmarks, 
history, font-settings, commands, media_galleries_private

After the introduction of templatized ProfileKeyedServiceFactory in 
https://chromiumcodereview.appspot.com/11649053, factories per
extension APIs are not needed anymore. 

BUG=159265
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177558

[tfarina, 2013-01-10 01:48:41]

On Wed, Jan 9, 2013 at 11:44 PM,  <MHX348@motorola.com> wrote:
> Reviewers: Yoyo Zhou,
>
> Description:
> Remove profile-keyed factory boilerplate : bookmarks, history,
> font-settings,
> commands, media_galleries_private
>
Could you improve this commit message? What you are removing, why? Can
you describe the benefit so later someone reading it can figure this
out alone?

> Patch from Joe Thomas <mhx348@motorola.com>.
>
I guess you don't need this line, as CQ gives the authority to you?

> BUG=159265
>
>
> Please review this at https://chromiumcodereview.appspot.com/11820041/
>
Thanks,

-- 
Thiago

[Joe Thomas, 2013-01-10 02:06:14]

On 2013/01/10 01:48:41, tfarina wrote:
> On Wed, Jan 9, 2013 at 11:44 PM,  <mailto:MHX348@motorola.com> wrote:
> > Reviewers: Yoyo Zhou,
> >
> > Description:
> > Remove profile-keyed factory boilerplate : bookmarks, history,
> > font-settings,
> > commands, media_galleries_private
> >
> Could you improve this commit message? What you are removing, why? Can
> you describe the benefit so later someone reading it can figure this
> out alone?
> 

Done

> > Patch from Joe Thomas <mailto:mhx348@motorola.com>.
> >
> I guess you don't need this line, as CQ gives the authority to you?
> 

http://www.chromium.org/developers/contributing-code says that non-committers
should include a message like this.

> > BUG=159265
> >
> >
> > Please review this at https://chromiumcodereview.appspot.com/11820041/
> >
> Thanks,
> 
> -- 
> Thiago

[Joe Thomas, 2013-01-15 18:38:45]

@Yoyo: friendly ping.

[Yoyo Zhou, 2013-01-15 19:48:16]

Sorry, I must have missed this one.

https://codereview.chromium.org/11820041/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/bookmarks/bookmark_api.h (left):

https://codereview.chromium.org/11820041/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/bookmarks/bookmark_api.h:1: // Copyright (c) 2012
The Chromium Authors. All rights reserved.
FYI, this file has been renamed in r176236; please rebase on trunk.

[Joe Thomas, 2013-01-16 00:07:57]

Patch Rebased. please review.

https://codereview.chromium.org/11820041/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/bookmarks/bookmark_api.h (left):

https://codereview.chromium.org/11820041/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/bookmarks/bookmark_api.h:1: // Copyright (c) 2012
The Chromium Authors. All rights reserved.
On 2013/01/15 19:48:16, Yoyo Zhou wrote:
> FYI, this file has been renamed in r176236; please rebase on trunk.

Done.

[Yoyo Zhou, 2013-01-16 00:58:36]

LGTM

[Joe Thomas, 2013-01-16 01:07:28]

+ ben for chrome/browser/ui/views/ & gyp changes
+ sail for chrome/browser/ui/cocoa/
+ estade for chrome/browser/ui/gtk/ & chrome/browser/ui/webui/
+ mirandac for chrome/browser/profiles/

[Joe Thomas, 2013-01-16 01:08:28]

+ ben for chrome/browser/ui/views/ & gyp changes
+ sail for chrome/browser/ui/cocoa/
+ estade for chrome/browser/ui/gtk/ & chrome/browser/ui/webui/
+ mirandac for chrome/browser/profiles/

[sail, 2013-01-16 01:12:42]

cocoa/* LGTM
Some nits about the CL description:
  summary should be a short line
  "are no more needed." -> "are not needed anymore".
  is the "Patch from Joe Thomas" part needed? It shows up correctly for me on
codereview.chromium.org under the "Created:" label.

[Joe Thomas, 2013-01-16 01:20:40]

On 2013/01/16 01:12:42, sail wrote:
> cocoa/* LGTM
> Some nits about the CL description:
>   summary should be a short line
>   "are no more needed." -> "are not needed anymore".

Done.

>   is the "Patch from Joe Thomas" part needed? It shows up correctly for me on
> http://codereview.chromium.org under the "Created:" label.

http://www.chromium.org/developers/contributing-code says that non-committers
should include a message like this. Anyhow I removed it.

[sail, 2013-01-16 01:24:49]

> http://www.chromium.org/developers/contributing-code says that non-committers
> should include a message like this. Anyhow I removed it.

I think that's meant for cases where the committer / reviewer uploads the CL. In
that case codereview.chromium.org won't show the correct author.

[Joe Thomas, 2013-01-16 01:27:02]

On 2013/01/16 01:24:49, sail wrote:
> > http://www.chromium.org/developers/contributing-code says that
non-committers
> > should include a message like this. Anyhow I removed it.
> 
> I think that's meant for cases where the committer / reviewer uploads the CL.
In
> that case http://codereview.chromium.org won't show the correct author.

Oh Ok. Thanks for the clarification.

[Evan Stade, 2013-01-16 03:51:43]

gtk and webui rslgtm

[Miranda Callahan, 2013-01-16 14:29:17]

On 2013/01/16 03:51:43, Evan Stade wrote:
> gtk and webui rslgtm

profiles/* LGTM

[Ben Goodger (Google), 2013-01-16 17:58:17]

gyp & ui/views lgtm

[commit-bot: I haz the power, 2013-01-17 00:24:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/MHX348@motorola.com/11820041/7001

[commit-bot: I haz the power, 2013-01-17 00:24:53]

Failed to apply patch for chrome/browser/profiles/profile_dependency_manager.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/profiles/profile_dependency_manager.cc
  Hunk #1 FAILED at 15.
  Hunk #2 succeeded at 252 (offset 2 lines).
  Hunk #3 succeeded at 269 (offset 2 lines).
  1 out of 3 hunks FAILED -- saving rejects to file
chrome/browser/profiles/profile_dependency_manager.cc.rej

Patch:       chrome/browser/profiles/profile_dependency_manager.cc
Index: chrome/browser/profiles/profile_dependency_manager.cc
diff --git a/chrome/browser/profiles/profile_dependency_manager.cc
b/chrome/browser/profiles/profile_dependency_manager.cc
index
4e974dedfcf7c3a6021c3051a3115c8805489817..9706cee289cc1dbe4a5f541903d5cf5f00003012
100644
--- a/chrome/browser/profiles/profile_dependency_manager.cc
+++ b/chrome/browser/profiles/profile_dependency_manager.cc
@@ -15,18 +15,18 @@
 #include "chrome/browser/custom_handlers/protocol_handler_registry_factory.h"
 #include "chrome/browser/download/download_service_factory.h"
 #include "chrome/browser/extensions/api/bluetooth/bluetooth_api_factory.h"
-#include "chrome/browser/extensions/api/bookmarks/bookmark_api_factory.h"
-#include "chrome/browser/extensions/api/commands/command_service_factory.h"
+#include "chrome/browser/extensions/api/bookmarks/bookmarks_api.h"
+#include "chrome/browser/extensions/api/commands/command_service.h"
 #include "chrome/browser/extensions/api/cookies/cookies_api.h"
 #include "chrome/browser/extensions/api/dial/dial_api_factory.h"
 #include
"chrome/browser/extensions/api/discovery/suggested_links_registry_factory.h"
 #include "chrome/browser/extensions/api/file_handlers/file_handlers_api.h"
-#include
"chrome/browser/extensions/api/font_settings/font_settings_api_factory.h"
-#include "chrome/browser/extensions/api/history/history_api_factory.h"
+#include "chrome/browser/extensions/api/font_settings/font_settings_api.h"
+#include "chrome/browser/extensions/api/history/history_api.h"
 #include "chrome/browser/extensions/api/idle/idle_manager_factory.h"
 #include "chrome/browser/extensions/api/managed_mode/managed_mode_api.h"
 #include "chrome/browser/extensions/api/management/management_api.h"
-#include
"chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api_factory.h"
+#include
"chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.h"
 #include "chrome/browser/extensions/api/omnibox/omnibox_api.h"
 #include "chrome/browser/extensions/api/preference/preference_api.h"
 #include "chrome/browser/extensions/api/processes/processes_api.h"
@@ -250,15 +250,15 @@ void ProfileDependencyManager::AssertFactoriesBuilt() {
   DownloadServiceFactory::GetInstance();
 #if defined(ENABLE_EXTENSIONS)
   extensions::AppRestoreServiceFactory::GetInstance();
-  extensions::BookmarkAPIFactory::GetInstance();
+  extensions::BookmarksAPI::GetFactoryInstance();
   extensions::BluetoothAPIFactory::GetInstance();
-  extensions::CommandServiceFactory::GetInstance();
+  extensions::CommandService::GetFactoryInstance();
   extensions::CookiesAPI::GetFactoryInstance();
   extensions::DialAPIFactory::GetInstance();
   extensions::ExtensionSystemFactory::GetInstance();
   extensions::FileHandlersAPI::GetFactoryInstance();
-  extensions::FontSettingsAPIFactory::GetInstance();
-  extensions::HistoryAPIFactory::GetInstance();
+  extensions::FontSettingsAPI::GetFactoryInstance();
+  extensions::HistoryAPI::GetFactoryInstance();
   extensions::IdleManagerFactory::GetInstance();
 #if defined(OS_CHROMEOS)
   extensions::InputImeAPI::GetFactoryInstance();
@@ -267,7 +267,7 @@ void ProfileDependencyManager::AssertFactoriesBuilt() {
   extensions::ManagedModeAPI::GetFactoryInstance();
   extensions::ManagementAPI::GetFactoryInstance();
   extensions::ManifestURLParser::GetFactoryInstance();
-  extensions::MediaGalleriesPrivateAPIFactory::GetInstance();
+  extensions::MediaGalleriesPrivateAPI::GetFactoryInstance();
 #if defined(OS_CHROMEOS)
   extensions::MediaPlayerAPI::GetFactoryInstance();
 #endif

[commit-bot: I haz the power, 2013-01-17 18:16:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/MHX348@motorola.com/11820041/19001

[commit-bot: I haz the power, 2013-01-17 18:16:09]

Failed to apply patch for
chrome/browser/ui/views/extensions/extension_installed_bubble.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/ui/views/extensions/extension_installed_bubble.cc
  Hunk #2 FAILED at 150.
  Hunk #3 FAILED at 179.
  2 out of 3 hunks FAILED -- saving rejects to file
chrome/browser/ui/views/extensions/extension_installed_bubble.cc.rej

Patch:       chrome/browser/ui/views/extensions/extension_installed_bubble.cc
Index: chrome/browser/ui/views/extensions/extension_installed_bubble.cc
diff --git a/chrome/browser/ui/views/extensions/extension_installed_bubble.cc
b/chrome/browser/ui/views/extensions/extension_installed_bubble.cc
index
e0ab37464d57e5baf03c324e8fbcfda33e08cb5b..25ea67669efd38df161ead5c63d98a7bc10229b3
100644
--- a/chrome/browser/ui/views/extensions/extension_installed_bubble.cc
+++ b/chrome/browser/ui/views/extensions/extension_installed_bubble.cc
@@ -12,7 +12,6 @@
 #include "base/message_loop.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/extensions/api/commands/command_service.h"
-#include "chrome/browser/extensions/api/commands/command_service_factory.h"
 #include "chrome/browser/extensions/extension_action.h"
 #include "chrome/browser/extensions/extension_action_manager.h"
 #include "chrome/browser/extensions/extension_install_ui.h"
@@ -151,8 +150,7 @@ class InstalledBubbleContent : public views::View,
     switch (type_) {
       case ExtensionInstalledBubble::BROWSER_ACTION: {
         extensions::CommandService* command_service =
-            extensions::CommandServiceFactory::GetForProfile(
-                browser_->profile());
+            extensions::CommandService::Get(browser_->profile());
         extensions::Command browser_action_command;
         if (!command_service->GetBrowserActionCommand(
                 extension->id(),
@@ -180,8 +178,7 @@ class InstalledBubbleContent : public views::View,
       }
       case ExtensionInstalledBubble::PAGE_ACTION: {
         extensions::CommandService* command_service =
-            extensions::CommandServiceFactory::GetForProfile(
-                browser_->profile());
+            extensions::CommandService::Get(browser_->profile());
         extensions::Command page_action_command;
         if (!command_service->GetPageActionCommand(
                 extension->id(),

[commit-bot: I haz the power, 2013-01-17 19:39:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/MHX348@motorola.com/11820041/22001

[commit-bot: I haz the power, 2013-01-17 21:34:37]

Retried try job too often on mac_rel for step(s) browser_tests

[commit-bot: I haz the power, 2013-01-17 21:48:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/MHX348@motorola.com/11820041/22001

[commit-bot: I haz the power, 2013-01-18 01:07:11]

Change committed as 177558