chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm - Issue 11820041: Remove profile-keyed factory boilerplates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

Issue 11820041: Remove profile-keyed factory boilerplates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/profiles/profile_dependency_manager.cc ('k') | chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

index dedb9bb85bd460999d6c138e009c86565b7fa55c..0e54d294278f836821a95b5b9ca1f6f3a81a8c8a 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

@@ -10,7 +10,6 @@

#include "base/sys_string_conversions.h"

#include "base/utf_string_conversions.h"

#include "chrome/browser/extensions/api/commands/command_service.h"

-#include "chrome/browser/extensions/api/commands/command_service_factory.h"

#include "chrome/browser/extensions/bundle_installer.h"

#include "chrome/browser/extensions/extension_action.h"

#include "chrome/browser/extensions/extension_action_manager.h"

@@ -296,7 +295,7 @@ class ExtensionLoadedNotificationObserver

- (bool)hasActivePageAction:(extensions::Command*)command {

extensions::CommandService* command_service =

- extensions::CommandServiceFactory::GetForProfile(browser_->profile());

+ extensions::CommandService::Get(browser_->profile());

if (type_ == extension_installed_bubble::kPageAction) {

if (extension_->page_action_command() &&

command_service->GetPageActionCommand(

@@ -313,7 +312,7 @@ class ExtensionLoadedNotificationObserver

- (bool)hasActiveBrowserAction:(extensions::Command*)command {

extensions::CommandService* command_service =

- extensions::CommandServiceFactory::GetForProfile(browser_->profile());

+ extensions::CommandService::Get(browser_->profile());

if (type_ == extension_installed_bubble::kBrowserAction) {

if (extension_->browser_action_command() &&

command_service->GetBrowserActionCommand(