Issue 11820018: Clean up: remove unnecessary if-branches on initialization of the a11y prefs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11820018: Clean up: remove unnecessary if-branches on initialization of the a11y prefs. (Closed)

Created:
7 years, 11 months ago by yoshiki

Modified:
7 years, 11 months ago

Reviewers:
Daniel Erat

CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Clean up: remove unnecessary if-branches on initialization of the a11y prefs. According to the comment at preferences.cc:96, some accessibility prefs may be already registered in WizardController::RegisterPrefs. But the magnifier prefs are never registered there, hence we can remove if statements. BUG=none TEST=launch ChromeOS, and login. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175826

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -18 lines)			Patch
	M	chrome/browser/chromeos/preferences.cc	View		2 chunks	+11 lines, -18 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/11820018/1

7 years, 11 months ago (2013-01-09 15:34:30 UTC) #3

Message was sent while issue was closed.

Change committed as 175826

Expand Messages | Collapse Messages