Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: chrome/browser/chromeos/preferences.cc

Issue 11820018: Clean up: remove unnecessary if-branches on initialization of the a11y prefs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/preferences.cc
diff --git a/chrome/browser/chromeos/preferences.cc b/chrome/browser/chromeos/preferences.cc
index 9316186938dd0df9701de01bc7384cedb60d3d2b..8ee9f98d188e8394c784d53710c3b1a5c844cbd0 100644
--- a/chrome/browser/chromeos/preferences.cc
+++ b/chrome/browser/chromeos/preferences.cc
@@ -93,9 +93,9 @@ void Preferences::RegisterUserPrefs(PrefServiceSyncable* prefs) {
prefs->RegisterBooleanPref(prefs::kLabsAdvancedFilesystemEnabled,
false,
PrefServiceSyncable::UNSYNCABLE_PREF);
- // Check if the accessibility pref is already registered, which can happen
+ // Check if the accessibility prefs are already registered, which can happen
// in WizardController::RegisterPrefs. We still want to try to register
- // the pref here in case of Chrome/Linux with ChromeOS=1.
+ // the prefs here in case of Chrome/Linux with ChromeOS=1.
if (prefs->FindPreference(prefs::kSpokenFeedbackEnabled) == NULL) {
prefs->RegisterBooleanPref(prefs::kSpokenFeedbackEnabled,
false,
@@ -106,27 +106,20 @@ void Preferences::RegisterUserPrefs(PrefServiceSyncable* prefs) {
false,
PrefServiceSyncable::UNSYNCABLE_PREF);
}
- if (prefs->FindPreference(prefs::kScreenMagnifierEnabled) == NULL) {
- prefs->RegisterBooleanPref(prefs::kScreenMagnifierEnabled,
- false,
- PrefServiceSyncable::SYNCABLE_PREF);
- }
- if (prefs->FindPreference(prefs::kScreenMagnifierScale) == NULL) {
- prefs->RegisterDoublePref(prefs::kScreenMagnifierScale,
- std::numeric_limits<double>::min(),
- PrefServiceSyncable::UNSYNCABLE_PREF);
- }
- if (prefs->FindPreference(prefs::kShouldAlwaysShowAccessibilityMenu) ==
- NULL) {
- prefs->RegisterBooleanPref(prefs::kShouldAlwaysShowAccessibilityMenu,
- false,
- PrefServiceSyncable::UNSYNCABLE_PREF);
- }
if (prefs->FindPreference(prefs::kVirtualKeyboardEnabled) == NULL) {
prefs->RegisterBooleanPref(prefs::kVirtualKeyboardEnabled,
false,
PrefServiceSyncable::UNSYNCABLE_PREF);
}
+ prefs->RegisterBooleanPref(prefs::kScreenMagnifierEnabled,
+ false,
+ PrefServiceSyncable::SYNCABLE_PREF);
+ prefs->RegisterDoublePref(prefs::kScreenMagnifierScale,
+ std::numeric_limits<double>::min(),
+ PrefServiceSyncable::UNSYNCABLE_PREF);
+ prefs->RegisterBooleanPref(prefs::kShouldAlwaysShowAccessibilityMenu,
+ false,
+ PrefServiceSyncable::UNSYNCABLE_PREF);
prefs->RegisterIntegerPref(prefs::kMouseSensitivity,
3,
PrefServiceSyncable::SYNCABLE_PREF);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698