Issue 11819016: [Autofill] Require callers to pass in locale when parsing named months like "January"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11819016: [Autofill] Require callers to pass in locale when parsing named months like "January" (Closed)

Created:
7 years, 11 months ago by Ilya Sherman

Modified:
7 years, 11 months ago

Reviewers:
dhollowa

CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Autofill] Require callers to pass in locale when parsing named months like "January" BUG=100845 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175732

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -10 lines)			Patch
M	chrome/browser/autofill/credit_card.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/autofill/credit_card.cc	View	6 chunks	+19 lines, -7 lines	0 comments	Download
M	chrome/browser/autofill/credit_card_unittest.cc	View	2 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/11819016/1

7 years, 11 months ago (2013-01-09 00:40:16 UTC) #3

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 11 months ago (2013-01-09 03:14:28 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/11819016/1

7 years, 11 months ago (2013-01-09 04:32:33 UTC) #5

Message was sent while issue was closed.

Change committed as 175732

Expand Messages | Collapse Messages