Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Side by Side Diff: chrome/browser/autofill/credit_card_unittest.cc

Issue 11819016: [Autofill] Require callers to pass in locale when parsing named months like "January" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/autofill/credit_card.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/basictypes.h" 5 #include "base/basictypes.h"
6 #include "base/utf_string_conversions.h" 6 #include "base/utf_string_conversions.h"
7 #include "chrome/browser/autofill/autofill_common_test.h" 7 #include "chrome/browser/autofill/autofill_common_test.h"
8 #include "chrome/browser/autofill/credit_card.h" 8 #include "chrome/browser/autofill/credit_card.h"
9 #include "chrome/common/form_field_data.h" 9 #include "chrome/common/form_field_data.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 TEST(CreditCardTest, SetRawInfoCreditCardNumber) { 157 TEST(CreditCardTest, SetRawInfoCreditCardNumber) {
158 CreditCard card; 158 CreditCard card;
159 159
160 autofill_test::SetCreditCardInfo(&card, "Bob Dylan", 160 autofill_test::SetCreditCardInfo(&card, "Bob Dylan",
161 "4321-5432-6543-xxxx", "07", "2013"); 161 "4321-5432-6543-xxxx", "07", "2013");
162 EXPECT_EQ(ASCIIToUTF16("4321-5432-6543-xxxx"), 162 EXPECT_EQ(ASCIIToUTF16("4321-5432-6543-xxxx"),
163 card.GetRawInfo(CREDIT_CARD_NUMBER)); 163 card.GetRawInfo(CREDIT_CARD_NUMBER));
164 } 164 }
165 165
166 // Verify that we can handle both numeric and named months. 166 // Verify that we can handle both numeric and named months.
167 TEST(CreditCardTest, SetRawInfoExpirationMonth) { 167 TEST(CreditCardTest, SetExpirationMonth) {
168 CreditCard card; 168 CreditCard card;
169 169
170 card.SetRawInfo(CREDIT_CARD_EXP_MONTH, ASCIIToUTF16("05")); 170 card.SetRawInfo(CREDIT_CARD_EXP_MONTH, ASCIIToUTF16("05"));
171 EXPECT_EQ(ASCIIToUTF16("05"), card.GetRawInfo(CREDIT_CARD_EXP_MONTH)); 171 EXPECT_EQ(ASCIIToUTF16("05"), card.GetRawInfo(CREDIT_CARD_EXP_MONTH));
172 172
173 card.SetRawInfo(CREDIT_CARD_EXP_MONTH, ASCIIToUTF16("7")); 173 card.SetRawInfo(CREDIT_CARD_EXP_MONTH, ASCIIToUTF16("7"));
174 EXPECT_EQ(ASCIIToUTF16("07"), card.GetRawInfo(CREDIT_CARD_EXP_MONTH)); 174 EXPECT_EQ(ASCIIToUTF16("07"), card.GetRawInfo(CREDIT_CARD_EXP_MONTH));
175 175
176 // This should fail, and preserve the previous value.
176 card.SetRawInfo(CREDIT_CARD_EXP_MONTH, ASCIIToUTF16("January")); 177 card.SetRawInfo(CREDIT_CARD_EXP_MONTH, ASCIIToUTF16("January"));
178 EXPECT_EQ(ASCIIToUTF16("07"), card.GetRawInfo(CREDIT_CARD_EXP_MONTH));
179
180 card.SetInfo(CREDIT_CARD_EXP_MONTH, ASCIIToUTF16("January"), "en-US");
177 EXPECT_EQ(ASCIIToUTF16("01"), card.GetRawInfo(CREDIT_CARD_EXP_MONTH)); 181 EXPECT_EQ(ASCIIToUTF16("01"), card.GetRawInfo(CREDIT_CARD_EXP_MONTH));
178 182
179 card.SetRawInfo(CREDIT_CARD_EXP_MONTH, ASCIIToUTF16("Apr")); 183 card.SetInfo(CREDIT_CARD_EXP_MONTH, ASCIIToUTF16("Apr"), "en-US");
180 EXPECT_EQ(ASCIIToUTF16("04"), card.GetRawInfo(CREDIT_CARD_EXP_MONTH)); 184 EXPECT_EQ(ASCIIToUTF16("04"), card.GetRawInfo(CREDIT_CARD_EXP_MONTH));
181 } 185 }
182 186
183 TEST(CreditCardTest, CreditCardType) { 187 TEST(CreditCardTest, CreditCardType) {
184 CreditCard card; 188 CreditCard card;
185 189
186 // The card type cannot be set directly. 190 // The card type cannot be set directly.
187 card.SetRawInfo(CREDIT_CARD_TYPE, ASCIIToUTF16("Visa")); 191 card.SetRawInfo(CREDIT_CARD_TYPE, ASCIIToUTF16("Visa"));
188 EXPECT_EQ(string16(), card.GetRawInfo(CREDIT_CARD_TYPE)); 192 EXPECT_EQ(string16(), card.GetRawInfo(CREDIT_CARD_TYPE));
189 193
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
349 353
350 { 354 {
351 // Case insensitivity: 355 // Case insensitivity:
352 CreditCard credit_card; 356 CreditCard credit_card;
353 credit_card.SetRawInfo(CREDIT_CARD_NUMBER, 357 credit_card.SetRawInfo(CREDIT_CARD_NUMBER,
354 ASCIIToUTF16("6011111111111117")); 358 ASCIIToUTF16("6011111111111117"));
355 credit_card.FillSelectControl(CREDIT_CARD_TYPE, &field); 359 credit_card.FillSelectControl(CREDIT_CARD_TYPE, &field);
356 EXPECT_EQ(ASCIIToUTF16("discover"), field.value); 360 EXPECT_EQ(ASCIIToUTF16("discover"), field.value);
357 } 361 }
358 } 362 }
OLDNEW
« no previous file with comments | « chrome/browser/autofill/credit_card.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698