OK, here's john's patch plus my sync stuff.

Enable browser_tests on linux_aura.

This patch is two parts:

- Disables some of the remaining failing/flaky tests so we can turn the rest of browser_tests on.
- Fix several places where we try to pass empty sizes to X11.

BUG=167114, 163931, 173621
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184284

[Elliot Glaysher, 2013-02-21 22:40:30]

BEHOLD!

After 37 patchsets, several back-and-forths with infrastructure over how the
linux_aura bots were configured, This patch enables browser_tests on linux_aura!
In the end, the problem was that IceWM was buggy; the problem wasn't even our
code (as I thought somewhere between patchsets 9 and 24)!

Note that the specific problem where timeouts were failing en mass has not
happened since patchset 33, which was the first which disabled IceWM. (n=12,
soon to be n=16 if the last round of tests pass.)

[jam, 2013-02-22 17:33:21]

lgtm

awesome for tracking this down!

(you'll also need a base and ui owner)

[Elliot Glaysher, 2013-02-22 17:43:02]

will, scott: i can haz stamps?

[sky, 2013-02-22 17:45:24]

LGTM

[willchan no longer on Chromium, 2013-02-22 17:49:27]

LGTM rubberstamp for the base/ change for the Aura MessagePump. That said,
someone *did* review that, right? I don't know who's qualified to review Aura
MessagePump changes...Scott? Ben?

Anyway, if it hasn't been reviewed, please make sure someone appropriate reviews
it.

[Elliot Glaysher, 2013-02-22 18:09:33]

Adding piman for base/.

This looks at the XEvent structure as we discussed maybe a month ago.

[piman, 2013-02-22 18:40:45]

lgtm

[commit-bot: I haz the power, 2013-02-22 18:45:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/11818065/52003

[commit-bot: I haz the power, 2013-02-22 18:46:05]

Failed to apply patch for chrome/browser/extensions/platform_app_browsertest.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/extensions/platform_app_browsertest.cc
  Hunk #1 FAILED at 787.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/extensions/platform_app_browsertest.cc.rej

Patch:       chrome/browser/extensions/platform_app_browsertest.cc
Index: chrome/browser/extensions/platform_app_browsertest.cc
diff --git a/chrome/browser/extensions/platform_app_browsertest.cc
b/chrome/browser/extensions/platform_app_browsertest.cc
index
cafa6c901c87338e8c85b9c7a80472763cbd15d5..8a027cd89ae6fabe527da65651a0321fbbfbfce3
100644
--- a/chrome/browser/extensions/platform_app_browsertest.cc
+++ b/chrome/browser/extensions/platform_app_browsertest.cc
@@ -787,7 +787,9 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest,
MAYBE_Messaging) {
 }
 
 // TODO(jeremya): this doesn't work on GTK yet. See http://crbug.com/159450.
-#if defined(TOOLKIT_GTK)
+//
+// TODO(linux_aura) http://crbug.com/163931
+#if defined(TOOLKIT_GTK) || (defined(OS_LINUX) && !defined(OS_CHROMEOS) &&
defined(USE_AURA))
 #define MAYBE_WebContentsHasFocus DISABLED_WebContentsHasFocus
 #else
 #define MAYBE_WebContentsHasFocus WebContentsHasFocus

[commit-bot: I haz the power, 2013-02-22 20:07:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/11818065/65002

[commit-bot: I haz the power, 2013-02-22 23:12:03]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-02-22 23:30:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/11818065/64005

[commit-bot: I haz the power, 2013-02-23 05:56:10]

Change committed as 184284