Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Side by Side Diff: chrome/browser/ui/browser_navigator_browsertest.cc

Issue 11818065: OK, here's john's patch plus my sync stuff. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Redisable PlatformAppBrowserTest.WebContentsHasFocus on aura Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser_navigator_browsertest.h" 5 #include "chrome/browser/ui/browser_navigator_browsertest.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/prefs/pref_service.h" 8 #include "base/prefs/pref_service.h"
9 #include "chrome/app/chrome_command_ids.h" 9 #include "chrome/app/chrome_command_ids.h"
10 #include "chrome/browser/prefs/incognito_mode_prefs.h" 10 #include "chrome/browser/prefs/incognito_mode_prefs.h"
(...skipping 1176 matching lines...) Expand 10 before | Expand all | Expand 10 after
1187 content::NOTIFICATION_LOAD_STOP, 1187 content::NOTIFICATION_LOAD_STOP,
1188 content::NotificationService::AllSources()); 1188 content::NotificationService::AllSources());
1189 chrome::ShowHistory(browser()); 1189 chrome::ShowHistory(browser());
1190 observer.Wait(); 1190 observer.Wait();
1191 } 1191 }
1192 EXPECT_EQ(1, browser()->tab_strip_model()->count()); 1192 EXPECT_EQ(1, browser()->tab_strip_model()->count());
1193 EXPECT_EQ(GURL(chrome::kChromeUIHistoryFrameURL), 1193 EXPECT_EQ(GURL(chrome::kChromeUIHistoryFrameURL),
1194 browser()->tab_strip_model()->GetActiveWebContents()->GetURL()); 1194 browser()->tab_strip_model()->GetActiveWebContents()->GetURL());
1195 } 1195 }
1196 1196
1197 // TODO(linux_aura) http://crbug.com/163931
1198 #if defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(USE_AURA)
1199 #define MAYBE_NavigateFromDefaultToBookmarksInSameTab DISABLED_NavigateFromDefau ltToBookmarksInSameTab
1200 #else
1201 #define MAYBE_NavigateFromDefaultToBookmarksInSameTab NavigateFromDefaultToBookm arksInSameTab
1202 #endif
1197 IN_PROC_BROWSER_TEST_F(BrowserNavigatorTest, 1203 IN_PROC_BROWSER_TEST_F(BrowserNavigatorTest,
1198 NavigateFromDefaultToBookmarksInSameTab) { 1204 MAYBE_NavigateFromDefaultToBookmarksInSameTab) {
1199 { 1205 {
1200 content::WindowedNotificationObserver observer( 1206 content::WindowedNotificationObserver observer(
1201 content::NOTIFICATION_LOAD_STOP, 1207 content::NOTIFICATION_LOAD_STOP,
1202 content::NotificationService::AllSources()); 1208 content::NotificationService::AllSources());
1203 chrome::ShowBookmarkManager(browser()); 1209 chrome::ShowBookmarkManager(browser());
1204 observer.Wait(); 1210 observer.Wait();
1205 } 1211 }
1206 EXPECT_EQ(1, browser()->tab_strip_model()->count()); 1212 EXPECT_EQ(1, browser()->tab_strip_model()->count());
1207 EXPECT_TRUE(StartsWithASCII( 1213 EXPECT_TRUE(StartsWithASCII(
1208 browser()->tab_strip_model()->GetActiveWebContents()->GetURL().spec(), 1214 browser()->tab_strip_model()->GetActiveWebContents()->GetURL().spec(),
(...skipping 27 matching lines...) Expand all
1236 // Now navigate using the incognito profile and check that a new window 1242 // Now navigate using the incognito profile and check that a new window
1237 // is created. 1243 // is created.
1238 chrome::NavigateParams params_incognito( 1244 chrome::NavigateParams params_incognito(
1239 browser()->profile()->GetOffTheRecordProfile(), 1245 browser()->profile()->GetOffTheRecordProfile(),
1240 GetGoogleURL(), content::PAGE_TRANSITION_LINK); 1246 GetGoogleURL(), content::PAGE_TRANSITION_LINK);
1241 ui_test_utils::NavigateToURL(&params_incognito); 1247 ui_test_utils::NavigateToURL(&params_incognito);
1242 EXPECT_EQ(2u, chrome::GetTotalBrowserCount()); 1248 EXPECT_EQ(2u, chrome::GetTotalBrowserCount());
1243 } 1249 }
1244 1250
1245 } // namespace 1251 } // namespace
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser_browsertest.cc ('k') | chrome/browser/ui/panels/panel_extension_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698