Adds option to enable CSS backgrounds for printing.

Adds option to enable CSS backgrounds for printing.

BUG=113594
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176617

[Vitaly Buka (NO REVIEWS), 2013-01-10 21:16:56]

https://codereview.chromium.org/11818062/diff/1/chrome/app/generated_resource...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/11818062/diff/1/chrome/app/generated_resource...
chrome/app/generated_resources.grd:8756: +        Background colors and images
Background colors and images -> Print background colors and images?

https://codereview.chromium.org/11818062/diff/1/chrome/renderer/print_web_vie...
File chrome/renderer/print_web_view_helper.cc (right):

https://codereview.chromium.org/11818062/diff/1/chrome/renderer/print_web_vie...
chrome/renderer/print_web_view_helper.cc:542:
static_cast<double>(print_layout_size.height()) * 1.25));
Probably you should set flag here.
PrepareFrameAndViewForPrint accept message params in constructor. You need store
that in boolean flag.
Also you should save that value and restore in ::FinishPrinting

[Toscano, 2013-01-10 22:27:25]

https://codereview.chromium.org/11818062/diff/1/chrome/app/generated_resource...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/11818062/diff/1/chrome/app/generated_resource...
chrome/app/generated_resources.grd:8756: +        Background colors and images
On 2013/01/10 21:16:56, Vitaly Buka wrote:
> Background colors and images -> Print background colors and images?

I'm trying to stay consistent with the other labels. We use "Headers and
footers", not "Print headers and footers" for example.

https://codereview.chromium.org/11818062/diff/1/chrome/renderer/print_web_vie...
File chrome/renderer/print_web_view_helper.cc (right):

https://codereview.chromium.org/11818062/diff/1/chrome/renderer/print_web_vie...
chrome/renderer/print_web_view_helper.cc:542:
static_cast<double>(print_layout_size.height()) * 1.25));
On 2013/01/10 21:16:56, Vitaly Buka wrote:
> Probably you should set flag here.
> PrepareFrameAndViewForPrint accept message params in constructor. You need
store
> that in boolean flag.
> Also you should save that value and restore in ::FinishPrinting

Done.

[Lei Zhang, 2013-01-10 23:30:10]

https://codereview.chromium.org/11818062/diff/1/chrome/renderer/print_web_vie...
File chrome/renderer/print_web_view_helper.cc (right):

https://codereview.chromium.org/11818062/diff/1/chrome/renderer/print_web_vie...
chrome/renderer/print_web_view_helper.cc:1300:
frame->view()->settings()->setShouldPrintBackgrounds(shouldPrintBackgrounds);
This probably should go into
PrintWebViewHelper::PrintPreviewContext::CreatePreviewDocument(), say, before we
reset |prep_frame_view_|.

In there, the code should be written as:
frame_->view()->settings()->setShouldPrintBackgrounds(print_params.should_print_backgrounds);

[Toscano, 2013-01-11 00:19:23]

https://codereview.chromium.org/11818062/diff/1/chrome/renderer/print_web_vie...
File chrome/renderer/print_web_view_helper.cc (right):

https://codereview.chromium.org/11818062/diff/1/chrome/renderer/print_web_vie...
chrome/renderer/print_web_view_helper.cc:1300:
frame->view()->settings()->setShouldPrintBackgrounds(shouldPrintBackgrounds);
On 2013/01/10 23:30:11, Lei Zhang wrote:
> This probably should go into
> PrintWebViewHelper::PrintPreviewContext::CreatePreviewDocument(), say, before
we
> reset |prep_frame_view_|.
> 
> In there, the code should be written as:
>
frame_->view()->settings()->setShouldPrintBackgrounds(print_params.should_print_backgrounds);

Hey Lei, I actually moved this to inside of the PrepareViewAndFrameForPrint
instead in the latest patch. Can you take a look at that?

[Vitaly Buka (NO REVIEWS), 2013-01-11 00:22:17]

lgtm

[Lei Zhang, 2013-01-11 00:30:04]

https://codereview.chromium.org/11818062/diff/4001/chrome/renderer/print_web_...
File chrome/renderer/print_web_view_helper.cc (right):

https://codereview.chromium.org/11818062/diff/4001/chrome/renderer/print_web_...
chrome/renderer/print_web_view_helper.cc:499: should_print_backgrounds_ =
print_params.should_print_backgrounds;
You can just put this in the initializer list.

[Toscano, 2013-01-11 01:41:05]

https://codereview.chromium.org/11818062/diff/4001/chrome/renderer/print_web_...
File chrome/renderer/print_web_view_helper.cc (right):

https://codereview.chromium.org/11818062/diff/4001/chrome/renderer/print_web_...
chrome/renderer/print_web_view_helper.cc:499: should_print_backgrounds_ =
print_params.should_print_backgrounds;
On 2013/01/11 00:30:04, Lei Zhang wrote:
> You can just put this in the initializer list.

Done.

[Lei Zhang, 2013-01-11 02:09:42]

c++ code lgtm

[commit-bot: I haz the power, 2013-01-11 03:05:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rltoscano@chromium.org/11818062/14001

[commit-bot: I haz the power, 2013-01-11 03:05:38]

Presubmit check for 11818062-14001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/common/print_messages.h

Presubmit checks took 3.9s to calculate.

[Toscano, 2013-01-11 17:48:24]

Hi Tom,

I've added a new field to the printing parameters, "should_print_backgrounds" in
chrome/common/print_messages.h that will allow the user to specify that they
want to print CSS backgrounds. Found you on the OWNERS file at chrome/common,
would you take a look please?

[Tom Sepez, 2013-01-11 18:10:57]

LGTM on adding a new bool parameter.

[commit-bot: I haz the power, 2013-01-11 18:11:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rltoscano@chromium.org/11818062/14001

[commit-bot: I haz the power, 2013-01-12 00:53:12]

Failed to apply patch for
chrome/browser/ui/webui/print_preview/print_preview_data_source.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
chrome/browser/ui/webui/print_preview/print_preview_data_source.cc
  Hunk #1 FAILED at 124.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/ui/webui/print_preview/print_preview_data_source.cc.rej

Patch:       chrome/browser/ui/webui/print_preview/print_preview_data_source.cc
Index: chrome/browser/ui/webui/print_preview/print_preview_data_source.cc
diff --git a/chrome/browser/ui/webui/print_preview/print_preview_data_source.cc
b/chrome/browser/ui/webui/print_preview/print_preview_data_source.cc
index
66a355c874374c1febade963a07508eb96879de7..aea6a35fdfafb0cb1da333fd88342720c68f79eb
100644
--- a/chrome/browser/ui/webui/print_preview/print_preview_data_source.cc
+++ b/chrome/browser/ui/webui/print_preview/print_preview_data_source.cc
@@ -124,6 +124,8 @@ void PrintPreviewDataSource::Init() {
                      IDS_PRINT_PREVIEW_OPTION_HEADER_FOOTER);
   AddLocalizedString("optionFitToPage",
                      IDS_PRINT_PREVIEW_OPTION_FIT_TO_PAGE);
+  AddLocalizedString("optionBackgroundColorsAndImages",
+                     IDS_PRINT_PREVIEW_OPTION_BACKGROUND_COLORS_AND_IMAGES);
   AddLocalizedString("marginsLabel", IDS_PRINT_PREVIEW_MARGINS_LABEL);
   AddLocalizedString("defaultMargins", IDS_PRINT_PREVIEW_DEFAULT_MARGINS);
   AddLocalizedString("noMargins", IDS_PRINT_PREVIEW_NO_MARGINS);

[commit-bot: I haz the power, 2013-01-12 01:10:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rltoscano@chromium.org/11818062/29001

[commit-bot: I haz the power, 2013-01-12 13:25:43]

Retried try job too often on win7_aura for step(s) browser_tests

[commit-bot: I haz the power, 2013-01-13 03:14:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rltoscano@chromium.org/11818062/29001

[commit-bot: I haz the power, 2013-01-14 00:59:48]

Change committed as 176617