Chromium Code Reviews
Help | Chromium Project | Sign in
(692)

Issue 11818062: Adds option to enable CSS backgrounds for printing. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 3 months ago by Toscano
Modified:
1 year, 3 months ago
CC:
chromium-reviews_chromium.org, arv, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Adds option to enable CSS backgrounds for printing.

BUG=113594
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176617

Patch Set 1 #

Total comments: 6

Patch Set 2 : Sets should-print-backgrounds setting via print job workers. #

Total comments: 2

Patch Set 3 : Move initialization of field to inializer list. #

Patch Set 4 : Merge with trunk. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+409 lines, -31 lines) Lint Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments ? errors Download
M chrome/browser/printing/printing_message_filter.cc View 1 1 chunk +1 line, -0 lines 0 comments ? errors Download
M chrome/browser/resources/print_preview/data/app_state.js View 6 chunks +30 lines, -1 line 0 comments ? errors Download
M chrome/browser/resources/print_preview/data/print_ticket_store.js View 3 chunks +38 lines, -0 lines 0 comments ? errors Download
A + chrome/browser/resources/print_preview/data/ticket_items/css_background.js View 3 chunks +7 lines, -20 lines 0 comments ? errors Download
M chrome/browser/resources/print_preview/native_layer.js View 1 2 3 2 chunks +3 lines, -1 line 0 comments ? errors Download
M chrome/browser/resources/print_preview/preview_generator.js View 3 chunks +11 lines, -0 lines 0 comments ? errors Download
M chrome/browser/resources/print_preview/print_preview.js View 1 2 3 1 chunk +1 line, -0 lines 0 comments ? errors Download
M chrome/browser/resources/print_preview/settings/other_options_settings.html View 1 chunk +6 lines, -0 lines 0 comments ? errors Download
M chrome/browser/resources/print_preview/settings/other_options_settings.js View 7 chunks +43 lines, -2 lines 0 comments ? errors Download
A chrome/browser/ui/webui/print_preview/print_preview_data_source.cc View 1 2 3 1 chunk +227 lines, -0 lines 0 comments ? errors Download
M chrome/common/print_messages.h View 2 chunks +4 lines, -0 lines 0 comments ? errors Download
M chrome/common/print_messages.cc View 2 chunks +3 lines, -1 line 0 comments ? errors Download
M chrome/renderer/print_web_view_helper.h View 1 2 chunks +4 lines, -3 lines 0 comments ? errors Download
M chrome/renderer/print_web_view_helper.cc View 1 2 6 chunks +11 lines, -2 lines 0 comments ? errors Download
M printing/print_job_constants.h View 1 chunk +1 line, -0 lines 0 comments ? errors Download
M printing/print_job_constants.cc View 1 chunk +3 lines, -0 lines 0 comments ? errors Download
M printing/print_settings.h View 1 1 chunk +3 lines, -0 lines 0 comments ? errors Download
M printing/print_settings.cc View 1 3 chunks +4 lines, -1 line 0 comments ? errors Download
M printing/printing_context.cc View 1 1 chunk +6 lines, -0 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 19
Toscano
1 year, 3 months ago #1
Vitaly Buka
https://codereview.chromium.org/11818062/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/11818062/diff/1/chrome/app/generated_resources.grd#newcode8756 chrome/app/generated_resources.grd:8756: + Background colors and images Background colors and images ...
1 year, 3 months ago #2
Toscano
https://codereview.chromium.org/11818062/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/11818062/diff/1/chrome/app/generated_resources.grd#newcode8756 chrome/app/generated_resources.grd:8756: + Background colors and images On 2013/01/10 21:16:56, Vitaly ...
1 year, 3 months ago #3
Lei Zhang
https://codereview.chromium.org/11818062/diff/1/chrome/renderer/print_web_view_helper.cc File chrome/renderer/print_web_view_helper.cc (right): https://codereview.chromium.org/11818062/diff/1/chrome/renderer/print_web_view_helper.cc#newcode1300 chrome/renderer/print_web_view_helper.cc:1300: frame->view()->settings()->setShouldPrintBackgrounds(shouldPrintBackgrounds); This probably should go into PrintWebViewHelper::PrintPreviewContext::CreatePreviewDocument(), say, before ...
1 year, 3 months ago #4
Toscano
https://codereview.chromium.org/11818062/diff/1/chrome/renderer/print_web_view_helper.cc File chrome/renderer/print_web_view_helper.cc (right): https://codereview.chromium.org/11818062/diff/1/chrome/renderer/print_web_view_helper.cc#newcode1300 chrome/renderer/print_web_view_helper.cc:1300: frame->view()->settings()->setShouldPrintBackgrounds(shouldPrintBackgrounds); On 2013/01/10 23:30:11, Lei Zhang wrote: > This ...
1 year, 3 months ago #5
Vitaly Buka
lgtm
1 year, 3 months ago #6
Lei Zhang
https://codereview.chromium.org/11818062/diff/4001/chrome/renderer/print_web_view_helper.cc File chrome/renderer/print_web_view_helper.cc (right): https://codereview.chromium.org/11818062/diff/4001/chrome/renderer/print_web_view_helper.cc#newcode499 chrome/renderer/print_web_view_helper.cc:499: should_print_backgrounds_ = print_params.should_print_backgrounds; You can just put this in ...
1 year, 3 months ago #7
Toscano
https://codereview.chromium.org/11818062/diff/4001/chrome/renderer/print_web_view_helper.cc File chrome/renderer/print_web_view_helper.cc (right): https://codereview.chromium.org/11818062/diff/4001/chrome/renderer/print_web_view_helper.cc#newcode499 chrome/renderer/print_web_view_helper.cc:499: should_print_backgrounds_ = print_params.should_print_backgrounds; On 2013/01/11 00:30:04, Lei Zhang wrote: ...
1 year, 3 months ago #8
Lei Zhang
c++ code lgtm
1 year, 3 months ago #9
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rltoscano@chromium.org/11818062/14001
1 year, 3 months ago #10
I haz the power (commit-bot)
Presubmit check for 11818062-14001 failed and returned exit status 1. Running presubmit commit checks ...
1 year, 3 months ago #11
Toscano
Hi Tom, I've added a new field to the printing parameters, "should_print_backgrounds" in chrome/common/print_messages.h that ...
1 year, 3 months ago #12
Tom Sepez
LGTM on adding a new bool parameter.
1 year, 3 months ago #13
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rltoscano@chromium.org/11818062/14001
1 year, 3 months ago #14
I haz the power (commit-bot)
Failed to apply patch for chrome/browser/ui/webui/print_preview/print_preview_data_source.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
1 year, 3 months ago #15
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rltoscano@chromium.org/11818062/29001
1 year, 3 months ago #16
I haz the power (commit-bot)
Retried try job too often on win7_aura for step(s) browser_tests
1 year, 3 months ago #17
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rltoscano@chromium.org/11818062/29001
1 year, 3 months ago #18
I haz the power (commit-bot)
1 year, 3 months ago #19
Message was sent while issue was closed.
Change committed as 176617
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6