Issue 11817028: Random fixes discovered when looking through CL 11824035.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11817028: Random fixes discovered when looking through CL 11824035. (Closed)

Created:
7 years, 11 months ago by floitsch

Modified:
7 years, 9 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Random fixes discovered when looking through CL 11824035. Committed: https://code.google.com/p/dart/source/detail?r=16878

Patch Set 2 : More fixes. #

Total comments: 2

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/compiler.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/pretty_parameter_test.dart	View	1	1 chunk	+1 line, -1 line	2 comments	Download
M	tests/language/double_to_string_as_exponential2_test.dart	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM, awesome! https://codereview.chromium.org/11817028/diff/2001/tests/compiler/dart2js/pretty_parameter_test.dart File tests/compiler/dart2js/pretty_parameter_test.dart (right): https://codereview.chromium.org/11817028/diff/2001/tests/compiler/dart2js/pretty_parameter_test.dart#newcode104 tests/compiler/dart2js/pretty_parameter_test.dart:104: Expect.isFalse(matches.moveNext()); Why didn't this turn into a ...

7 years, 11 months ago (2013-01-09 20:09:39 UTC) #2

floitsch

7 years, 9 months ago (2013-03-04 15:26:27 UTC) #3

Message was sent while issue was closed.

Forgot to submit comment.

https://chromiumcodereview.appspot.com/11817028/diff/2001/tests/compiler/dart...
File tests/compiler/dart2js/pretty_parameter_test.dart (right):

https://chromiumcodereview.appspot.com/11817028/diff/2001/tests/compiler/dart...
tests/compiler/dart2js/pretty_parameter_test.dart:104:
Expect.isFalse(matches.moveNext());
On 2013/01/09 20:09:39, ahe wrote:
> Why didn't this turn into a test failure?

Because the test was already marked as failing.

Expand Messages | Collapse Messages

Issue 11817028: Random fixes discovered when looking through CL 11824035. (Closed)

Description

Patch Set 1 #

Patch Set 2 : More fixes. #

Messages