Fix sync signed in text from being too small.

Fix sync signed in text from being too small.

Desktop updated the default size for web ui pages to be
75% of the default browser height.  We don't want the font
size on this page to be dependent, so I'm removing that inclusion
for the welcome page.

Here's the change updating it to 75% (and it's about a year old...
is that how old m18 is?)
https://chromiumcodereview.appspot.com/9328020

BUG=168388
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175763

[newt (away), 2013-01-08 00:52:41]

Do you want to update chrome/browser/ui/webui/chrome_url_data_manager.cc as well
to ifdef out the line that sets the fontsize value?

[Ted C, 2013-01-08 01:00:56]

On 2013/01/08 00:52:41, newt wrote:
> Do you want to update chrome/browser/ui/webui/chrome_url_data_manager.cc as
well
> to ifdef out the line that sets the fontsize value?

I don't know if we want to do that across all our webui pages.  Especially ones
we share with desktop that have font sizes updated correctly.

[newt (away), 2013-01-08 01:09:46]

On 2013/01/08 01:00:56, Ted C wrote:
> On 2013/01/08 00:52:41, newt wrote:
> > Do you want to update chrome/browser/ui/webui/chrome_url_data_manager.cc as
> well
> > to ifdef out the line that sets the fontsize value?
> 
> I don't know if we want to do that across all our webui pages.  Especially
ones
> we share with desktop that have font sizes updated correctly.

Gotcha. For example, NTP uses this smaller font size.

lgtm.

[commit-bot: I haz the power, 2013-01-08 01:12:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tedchoc@chromium.org/11801031/1

[commit-bot: I haz the power, 2013-01-08 01:12:20]

Presubmit check for 11801031-1 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/resources

[Ted C, 2013-01-08 01:16:16]

+estade for owners

[Evan Stade, 2013-01-08 02:05:36]

don't want it to be dependent on what? Instead of changing the boilerplate, you
should increase the size of the particular span that you want abnormally large
text for.

[Ted C, 2013-01-08 03:37:24]

Dependent on the font size setting in the resources.  This is the only text
on the page and it seems overkill to inherit the webui default just to have
to compensate the text size to have it readable.

75% on a phone is quite small with a fixed position viewport.  And if this
default font size is changed then you'll need to change this page, which
wouldn't be the case with this change.
On Jan 7, 2013 6:05 PM, <estade@chromium.org> wrote:

> don't want it to be dependent on what? Instead of changing the
> boilerplate, you
> should increase the size of the particular span that you want abnormally
> large
> text for.
>
>
https://chromiumcodereview.**appspot.com/11801031/<https://chromiumcodereview...
>

[Evan Stade, 2013-01-08 20:45:05]

On 2013/01/08 03:37:24, Ted C wrote:
> Dependent on the font size setting in the resources.  This is the only text
> on the page and it seems overkill to inherit the webui default just to have
> to compensate the text size to have it readable.

it's the only text until someone adds another span somewhere. I consider it
coincidental that this even works (for example, if you wanted 18px instead of
16px for this span, you'd still have to add a CSS rule).

> 
> 75% on a phone is quite small with a fixed position viewport.  And if this
> default font size is changed then you'll need to change this page, which
> wouldn't be the case with this change.

if the default is changed, it's because we want the font to change everywhere,
so this is a plus.

> On Jan 7, 2013 6:05 PM, <mailto:estade@chromium.org> wrote:
> 
> > don't want it to be dependent on what? Instead of changing the
> > boilerplate, you
> > should increase the size of the particular span that you want abnormally
> > large
> > text for.
> >
> >
>
https://chromiumcodereview.**appspot.com/11801031/%3Chttps://chromiumcoderevi...>
> >

[Ted C, 2013-01-08 22:30:19]

Updated with an explicit size instead.

On 2013/01/08 20:45:05, Evan Stade wrote:
> On 2013/01/08 03:37:24, Ted C wrote:
> > Dependent on the font size setting in the resources.  This is the only text
> > on the page and it seems overkill to inherit the webui default just to have
> > to compensate the text size to have it readable.
> 
> it's the only text until someone adds another span somewhere. I consider it
> coincidental that this even works (for example, if you wanted 18px instead of
> 16px for this span, you'd still have to add a CSS rule).
> 
> > 
> > 75% on a phone is quite small with a fixed position viewport.  And if this
> > default font size is changed then you'll need to change this page, which
> > wouldn't be the case with this change.
> 
> if the default is changed, it's because we want the font to change everywhere,
> so this is a plus.
> 
> > On Jan 7, 2013 6:05 PM, <mailto:estade@chromium.org> wrote:
> > 
> > > don't want it to be dependent on what? Instead of changing the
> > > boilerplate, you
> > > should increase the size of the particular span that you want abnormally
> > > large
> > > text for.
> > >
> > >
> >
>
https://chromiumcodereview.**appspot.com/11801031/%253Chttps://chromiumcodere...>
> > >

[Evan Stade, 2013-01-09 00:41:55]

https://codereview.chromium.org/11801031/diff/6001/chrome/browser/resources/a...
File chrome/browser/resources/about_welcome_android/about_welcome_android.css
(right):

https://codereview.chromium.org/11801031/diff/6001/chrome/browser/resources/a...
chrome/browser/resources/about_welcome_android/about_welcome_android.css:45:
font-size: 16px;
this should be 1.3em because then it will depend on the user's default font size
setting (which is a good thing).

[Ted C, 2013-01-09 00:56:55]

https://codereview.chromium.org/11801031/diff/6001/chrome/browser/resources/a...
File chrome/browser/resources/about_welcome_android/about_welcome_android.css
(right):

https://codereview.chromium.org/11801031/diff/6001/chrome/browser/resources/a...
chrome/browser/resources/about_welcome_android/about_welcome_android.css:45:
font-size: 16px;
On 2013/01/09 00:41:55, Evan Stade wrote:
> this should be 1.3em because then it will depend on the user's default font
size
> setting (which is a good thing).

Done.

[Evan Stade, 2013-01-09 01:05:55]

thanks, lgtm

[commit-bot: I haz the power, 2013-01-09 01:07:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tedchoc@chromium.org/11801031/10001

[commit-bot: I haz the power, 2013-01-09 05:10:28]

Retried try job too often on win_aura for step(s) content_browsertests

[commit-bot: I haz the power, 2013-01-09 07:24:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tedchoc@chromium.org/11801031/10001

[commit-bot: I haz the power, 2013-01-09 10:19:45]

Change committed as 175763