Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 9328020: [uber page] Update web-ui font settings (Closed)

Created:
8 years, 10 months ago by csilv
Modified:
8 years, 10 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, Aaron Boodman, finnur+watch_chromium.org, arv (Not doing code reviews), jshin+watch_chromium.org, mihaip+watch_chromium.org
Visibility:
Public.

Description

[uber page] Update web-ui font settings. - Use 'Open Sans' on desktop versions. - Windows: Fallback to 'Segoe UI' on Vista, or Arial on XP. - Adopt shared webui font settings for uber page. BUG=100885, 112905 TEST=Manual inspection of fonts for webui. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120666

Patch Set 1 : '' #

Patch Set 2 : Change default web-ui font size per Glen #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -25 lines) Patch
M chrome/app/resources/locale_settings_linux.grd View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/resources/locale_settings_mac.grd View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/resources/locale_settings_win.grd View 1 2 1 chunk +10 lines, -2 lines 0 comments Download
M chrome/app/resources/platform_locale_settings/locale_settings_win_bn.xtb View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/app/resources/platform_locale_settings/locale_settings_win_ja.xtb View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/app/resources/platform_locale_settings/locale_settings_win_ko.xtb View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/app/resources/platform_locale_settings/locale_settings_win_ml.xtb View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/app/resources/platform_locale_settings/locale_settings_win_th.xtb View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/app/resources/platform_locale_settings/locale_settings_win_zh-CN.xtb View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/app/resources/platform_locale_settings/locale_settings_win_zh-TW.xtb View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/extensions/extensions.html View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/options2/options.html View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/shared/css/chrome_shared2.css View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/resources/uber/uber_frame.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_url_data_manager.cc View 1 2 1 chunk +9 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
csilv
+estade for review This CL effectively bumps up the uber page font size slightly (12px ...
8 years, 10 months ago (2012-02-04 02:16:59 UTC) #1
csilv
On 2012/02/04 02:16:59, csilv wrote: > +estade for review > > This CL effectively bumps ...
8 years, 10 months ago (2012-02-06 19:12:49 UTC) #2
Evan Stade
this is great
8 years, 10 months ago (2012-02-06 19:57:46 UTC) #3
csilv
changed default web-ui font-size to 12px (ie, 75%) per Glen. FYI, specifying the body font ...
8 years, 10 months ago (2012-02-06 21:40:38 UTC) #4
Evan Stade
8 years, 10 months ago (2012-02-06 22:22:13 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698