Issue 11794032: base: Update the calls from MessageLoop::Quit() to QuitWhenIdle().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11794032: base: Update the calls from MessageLoop::Quit() to QuitWhenIdle(). (Closed)

Created:
7 years, 11 months ago by tfarina

Modified:
7 years, 11 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

base: Update the calls from MessageLoop::Quit() to QuitWhenIdle(). Quit() is deprecated and we should switch to QuitWhenIdle(). BUG=131220 R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176082

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -31 lines)			Patch
M	base/cancelable_callback.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/file_util_proxy_unittest.cc	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	base/message_loop_proxy_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/message_loop_unittest.cc	View	7 chunks	+8 lines, -8 lines	0 comments	Download
M	base/message_pump_glib_unittest.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	base/synchronization/waitable_event_watcher_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/threading/thread.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	base/timer_unittest.cc	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	base/win/object_watcher_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11794032/1

7 years, 11 months ago (2013-01-10 11:42:28 UTC) #3

commit-bot: I haz the power

Retried try job too often on win for step(s) compile

7 years, 11 months ago (2013-01-10 12:04:11 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11794032/1

7 years, 11 months ago (2013-01-10 12:30:35 UTC) #5

Message was sent while issue was closed.

Change committed as 176082