Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: base/message_loop_unittest.cc

Issue 11794032: base: Update the calls from MessageLoop::Quit() to QuitWhenIdle(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/message_loop_proxy_unittest.cc ('k') | base/message_pump_glib_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/message_loop_unittest.cc
diff --git a/base/message_loop_unittest.cc b/base/message_loop_unittest.cc
index ba37b2fcd640e2e3804a079b8589eb31136d029e..e7b8961a6efa71436b936c21ee3ffbcaa40ff92d 100644
--- a/base/message_loop_unittest.cc
+++ b/base/message_loop_unittest.cc
@@ -146,7 +146,7 @@ void RunTest_PostTask_SEH(MessageLoop::Type message_loop_type) {
static void SlowFunc(TimeDelta pause, int* quit_counter) {
PlatformThread::Sleep(pause);
if (--(*quit_counter) == 0)
- MessageLoop::current()->Quit();
+ MessageLoop::current()->QuitWhenIdle();
}
// This function records the time when Run was called in a Time object, which is
@@ -341,7 +341,7 @@ void SubPumpFunc() {
TranslateMessage(&msg);
DispatchMessage(&msg);
}
- MessageLoop::current()->Quit();
+ MessageLoop::current()->QuitWhenIdle();
}
void RunTest_PostDelayedTask_SharedTimer_SubPump() {
@@ -459,7 +459,7 @@ void NestingFunc(int* depth) {
MessageLoop::current()->SetNestableTasksAllowed(true);
MessageLoop::current()->Run();
}
- MessageLoop::current()->Quit();
+ MessageLoop::current()->QuitWhenIdle();
}
#if defined(OS_WIN)
@@ -502,7 +502,7 @@ class Crasher : public base::RefCounted<Crasher> {
#error "needs architecture support"
#endif
- MessageLoop::current()->Quit();
+ MessageLoop::current()->QuitWhenIdle();
}
// Points the bad array to a valid memory location.
static void FixError() {
@@ -726,7 +726,7 @@ void RecursiveSlowFunc(TaskList* order, int cookie, int depth,
void QuitFunc(TaskList* order, int cookie) {
order->RecordStart(QUITMESSAGELOOP, cookie);
- MessageLoop::current()->Quit();
+ MessageLoop::current()->QuitWhenIdle();
order->RecordEnd(QUITMESSAGELOOP, cookie);
}
@@ -1780,7 +1780,7 @@ void PostNTasksThenQuit(int posts_remaining) {
FROM_HERE,
base::Bind(&PostNTasksThenQuit, posts_remaining - 1));
} else {
- MessageLoop::current()->Quit();
+ MessageLoop::current()->QuitWhenIdle();
}
}
@@ -1892,10 +1892,10 @@ namespace {
class QuitDelegate : public MessageLoopForIO::Watcher {
public:
virtual void OnFileCanWriteWithoutBlocking(int fd) OVERRIDE {
- MessageLoop::current()->Quit();
+ MessageLoop::current()->QuitWhenIdle();
}
virtual void OnFileCanReadWithoutBlocking(int fd) OVERRIDE {
- MessageLoop::current()->Quit();
+ MessageLoop::current()->QuitWhenIdle();
}
};
« no previous file with comments | « base/message_loop_proxy_unittest.cc ('k') | base/message_pump_glib_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698