[Android] Fix Java android.view.Surface leak.

[Android] Fix Java android.view.Surface leak.

Correctly clean up resources when we're finished with the Surface
by invoking release().

Android only change and android bots are green.
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175536

[benm (inactive), 2013-01-07 19:30:00]

ptal

[no sievers, 2013-01-07 19:36:42]

On 2013/01/07 19:30:00, benm wrote:
> ptal

lgtm

[benm (inactive), 2013-01-08 11:31:56]

+marcus for content/common/android OWNERS

ptal, thanks!

[bulach, 2013-01-08 15:51:49]

lgtm, small suggestion below:

https://codereview.chromium.org/11791027/diff/1/content/common/android/surfac...
File content/common/android/surface_texture_bridge.cc (right):

https://codereview.chromium.org/11791027/diff/1/content/common/android/surfac...
content/common/android/surface_texture_bridge.cc:131:
JNI_Surface::Java_Surface_release(env, jsurface.obj());
rather than .obj() you may want to use .Release() so that the ref will be
invalid from then on..

[benm (inactive), 2013-01-08 15:56:38]

thanks marcus, unless I misunderstood or you have strong feelings think i'll
leave as is.

https://codereview.chromium.org/11791027/diff/1/content/common/android/surfac...
File content/common/android/surface_texture_bridge.cc (right):

https://codereview.chromium.org/11791027/diff/1/content/common/android/surfac...
content/common/android/surface_texture_bridge.cc:131:
JNI_Surface::Java_Surface_release(env, jsurface.obj());
Well, it's a scopedref that's going out of scope on the next line ... though
would stop anyone putting code inbetween release and the return i guess.

[commit-bot: I haz the power, 2013-01-08 16:32:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benm@chromium.org/11791027/1

[commit-bot: I haz the power, 2013-01-08 16:32:53]

Change committed as 175536