Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: content/common/android/surface_texture_bridge.cc

Issue 11791027: [Android] Fix Java android.view.Surface leak. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/android/surface_texture_bridge.cc
diff --git a/content/common/android/surface_texture_bridge.cc b/content/common/android/surface_texture_bridge.cc
index bdf54eeb0a2a6dd88ae2f3c59837fcf4e42670b6..5c9d800dfafa381bd64eb58852a15981d4fd3038 100644
--- a/content/common/android/surface_texture_bridge.cc
+++ b/content/common/android/surface_texture_bridge.cc
@@ -128,6 +128,7 @@ ANativeWindow* SurfaceTextureBridge::CreateSurface() {
env, j_surface_texture_.obj()));
DCHECK(!jsurface.is_null());
ANativeWindow* native_window = ANativeWindow_fromSurface(env, jsurface.obj());
+ JNI_Surface::Java_Surface_release(env, jsurface.obj());
bulach 2013/01/08 15:51:49 rather than .obj() you may want to use .Release()
benm (inactive) 2013/01/08 15:56:39 Well, it's a scopedref that's going out of scope o
return native_window;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698