Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Issue 11789003: Fixed a clipboard bug in views/omnibox. The content was always copied as pure text, never as hyperl… (Closed)

Created:
7 years, 11 months ago by vasilii
Modified:
7 years, 11 months ago
Reviewers:
dominich, sky
CC:
chromium-reviews, tfarina, James Su
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fixed a clipboard bug in views/omnibox. The content was always copied as pure text, never as hyperlink. BUG=168583 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176656

Patch Set 1 #

Patch Set 2 : Proper punctuation #

Patch Set 3 : added interactive test #

Patch Set 4 : Fixed Windows omnibox and unittest #

Patch Set 5 : Tweaked the test for MAC #

Patch Set 6 : Removed constraint on win_aura #

Patch Set 7 : Style changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -24 lines) Patch
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 1 2 3 4 5 6 2 chunks +39 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 1 2 3 4 5 6 3 chunks +16 lines, -17 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_win.cc View 1 2 3 4 chunks +16 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
vasilii
Hello Dominic, Could you please review the change list? Description available in bug report. Thanks, ...
7 years, 11 months ago (2013-01-07 18:14:47 UTC) #1
dominich
LGTM nice catch :)
7 years, 11 months ago (2013-01-07 18:36:07 UTC) #2
vasilii
Hi Scott, Could you please do the owners review? You reviewed the change list that ...
7 years, 11 months ago (2013-01-07 18:45:56 UTC) #3
sky
Please add a test for coverage.
7 years, 11 months ago (2013-01-07 22:05:37 UTC) #4
vasilii
Added ui test, fixed Windows implementation
7 years, 11 months ago (2013-01-11 18:33:45 UTC) #5
sky
LGTM
7 years, 11 months ago (2013-01-11 19:03:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vasilii@chromium.org/11789003/15015
7 years, 11 months ago (2013-01-14 08:44:24 UTC) #7
commit-bot: I haz the power
7 years, 11 months ago (2013-01-14 11:02:45 UTC) #8
Message was sent while issue was closed.
Change committed as 176656

Powered by Google App Engine
This is Rietveld 408576698