Issue 11788023: Type check fixes for Dartium tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11788023: Type check fixes for Dartium tests. (Closed)

Created:
7 years, 11 months ago by vsm

Modified:
7 years, 11 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Type check fixes for Dartium tests. Note: I'm seeing the following in checked mode: FAIL Expectation: queryAll-where. Caught type 'WhereIterable<Element>' is not a subtype of type 'Iterable<CanvasElement>' of 'canvases'. I only fixed what's necessary to get the tests green (I hope), but perhaps other allocation sites should be fixed to remove the generic. Committed: https://code.google.com/p/dart/source/detail?r=16773

Patch Set 1 #

Total comments: 1

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	tools/dom/templates/html/impl/impl_Element.darttemplate	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	tools/dom/templates/html/impl/impl_HTMLSelectElement.darttemplate	View		1 chunk	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

blois

7 years, 11 months ago (2013-01-08 00:02:24 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/11788023/diff/1/tools/dom/templates/ht...
File tools/dom/templates/html/impl/impl_HTMLSelectElement.darttemplate (left):

https://chromiumcodereview.appspot.com/11788023/diff/1/tools/dom/templates/ht...
tools/dom/templates/html/impl/impl_HTMLSelectElement.darttemplate:22: return new
ListView<OptionElement>(options, 0, options.length);
is there a bug on this? This seems like it's the correct syntax, no?

Expand Messages | Collapse Messages