New FileSystemURL cracking

webkit/fileapi/external_mount_points.h

Index: webkit/fileapi/external_mount_points.h
diff --git a/webkit/fileapi/external_mount_points.h b/webkit/fileapi/external_mount_points.h
index fe8d4d08779fdc74321939f131975117d968abec..5fc9e6b51f3ff328ab15aa9112f2c4e6814d776b 100644
--- a/webkit/fileapi/external_mount_points.h
+++ b/webkit/fileapi/external_mount_points.h
@@ -18,6 +18,7 @@
 class FilePath;
 
 namespace fileapi {
+class FileSystemURL;
 class RemoteFileSystemProxyInterface;
 }
 
@@ -70,6 +71,14 @@ class WEBKIT_STORAGE_EXPORT ExternalMountPoints
 
   // MountPoints overrides.
   virtual bool RevokeFileSystem(const std::string& mount_name) OVERRIDE;
+  virtual bool CanHandleURL(const FileSystemURL& url) const OVERRIDE;
+  virtual FileSystemURL CrackFileSystemURL(
+      const FileSystemURL& url) const OVERRIDE;

[kinuko, 2013/01/21 06:57:33]

Now these two methods (CanHandleURL and CrackFileSystemURL) should we expose
these methods only to trusted parties (e.g. ExternalMountPointsTest and
FileSystemContext)?  Because we no longer have is_cracked flag in FileSystemURL
having these public methods look confusing.
(Ditto for Isolated ones)

[tbarzic, 2013/01/22 21:30:56]

ok, I got rid of CrackFileSystemURL (and use CreateCrackedFileSystem instead).
Also removed FileSystemURL::CreateForCrackedURL and started using ctor irectly.

Changed CanHandleURL to HandlesFielSystemMountType (which seems closer to what
the method actually does)

+  virtual FileSystemURL CrackURL(const GURL& url) const OVERRIDE;
+  virtual FileSystemURL CreateCrackedFileSystemURL(
+      const GURL& origin,
+      FileSystemType type,
+      const FilePath& path) const OVERRIDE;
   virtual bool GetRegisteredPath(const std::string& mount_name,
                                  FilePath* path) const OVERRIDE;
   virtual bool CrackVirtualPath(const FilePath& virtual_path,