New FileSystemURL cracking

webkit/fileapi/external_mount_points.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_FILEAPI_EXTERNAL_MOUNT_POINTS_H_
 #define WEBKIT_FILEAPI_EXTERNAL_MOUNT_POINTS_H_
 
 #include <map>
 #include <string>
 #include <vector>
 
 #include "base/memory/ref_counted.h"
 #include "base/synchronization/lock.h"
 #include "webkit/fileapi/file_system_types.h"
 #include "webkit/fileapi/mount_points.h"
 #include "webkit/storage/webkit_storage_export.h"
 
 class FilePath;
 
 namespace fileapi {
+class FileSystemURL;
 class RemoteFileSystemProxyInterface;
 }
 
 namespace fileapi {
 
 // Manages external filesystem namespaces that are identified by 'mount name'
 // and are persisted until RevokeFileSystem is called.
 // Files in an external filesystem are identified by a filesystem URL like:
 //
 //   filesystem:<origin>/external/<mount_name>/relative/path
@@ skipping 32 matching lines @@
 
   // Same as |RegisterExternalFileSystem|, but also registers a remote file
   // system proxy for the file system.
   bool RegisterRemoteFileSystem(const std::string& mount_name,
                                 FileSystemType type,
                                 RemoteFileSystemProxyInterface* remote_proxy,
                                 const FilePath& path);
 
   // MountPoints overrides.
   virtual bool RevokeFileSystem(const std::string& mount_name) OVERRIDE;
+  virtual bool CanHandleURL(const FileSystemURL& url) const OVERRIDE;
+  virtual FileSystemURL CrackFileSystemURL(
+      const FileSystemURL& url) const OVERRIDE;

[kinuko, 2013/01/21 06:57:33]

Now these two methods (CanHandleURL and CrackFileSystemURL) should we expose
these methods only to trusted parties (e.g. ExternalMountPointsTest and
FileSystemContext)?  Because we no longer have is_cracked flag in FileSystemURL
having these public methods look confusing.
(Ditto for Isolated ones)

[tbarzic, 2013/01/22 21:30:56]

ok, I got rid of CrackFileSystemURL (and use CreateCrackedFileSystem instead).
Also removed FileSystemURL::CreateForCrackedURL and started using ctor irectly.

Changed CanHandleURL to HandlesFielSystemMountType (which seems closer to what
the method actually does)

+  virtual FileSystemURL CrackURL(const GURL& url) const OVERRIDE;
+  virtual FileSystemURL CreateCrackedFileSystemURL(
+      const GURL& origin,
+      FileSystemType type,
+      const FilePath& path) const OVERRIDE;
   virtual bool GetRegisteredPath(const std::string& mount_name,
                                  FilePath* path) const OVERRIDE;
   virtual bool CrackVirtualPath(const FilePath& virtual_path,
                                 std::string* mount_name,
                                 FileSystemType* type,
                                 FilePath* path) const OVERRIDE;
 
   // Retrieves the remote file system proxy for the registered file system.
   // Returns NULL if there is no file system with the given name, or if the file
   // system does not have a remote file system proxy.
@@ skipping 63 matching lines @@
   FilePath GetVirtualRootPath() const;
 
  private:
   const std::string mount_name_;
 };
 
 }  // namespace fileapi
 
 #endif  // WEBKIT_FILEAPI_EXTERNAL_MOUNT_POINTS_H_