chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc - Issue 11787028: New FileSystemURL cracking

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc

Issue 11787028: New FileSystemURL cracking (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Couple of nits I noticed Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/drive/drive_task_executor.cc ('K') | « chrome/browser/extensions/api/sync_file_system/sync_file_system_api.cc ('k') | content/browser/fileapi/fileapi_message_filter.cc » ('j') | webkit/fileapi/external_mount_points.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc

diff --git a/chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc b/chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc

index 4cefacc11fb4db08148d144374c634f49ee07400..976f1652277be9740b1f660ae8d66a74f66013bf 100644

--- a/chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc

+++ b/chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc

@@ -75,9 +75,10 @@ ACTION_P2(UpdateRemoteChangeQueue, origin, mock_remote_service) {

}

ACTION_P2(ReturnWithFakeFileAddedStatus, origin, mock_remote_service) {

- fileapi::FileSystemURL mock_url(*origin,

- fileapi::kFileSystemTypeTest,

- FilePath(FILE_PATH_LITERAL("foo")));

+ fileapi::FileSystemURL mock_url =

+ fileapi::FileSystemURL::CreateForTest(*origin,

+ fileapi::kFileSystemTypeTest,

+ FilePath(FILE_PATH_LITERAL("foo")));

mock_remote_service->NotifyRemoteChangeQueueUpdated(0);

base::MessageLoopProxy::current()->PostTask(

FROM_HERE, base::Bind(arg1,