chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc - Issue 11786003: Move Icons out of Extension class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc

Issue 11786003: Move Icons out of Extension class (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_browser_action

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/api/extension_action/script_badge_handler.cc ('K') | « chrome/common/extensions/api/extension_action/script_badge_handler.cc ('k') | chrome/common/extensions/api/icons/icons_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc

diff --git a/chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc b/chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc

index 605499cbac1ab14ad522390018a693abf06217c2..8dbdd7ac36dd4d14c2dcb4d4f307b911c62d2969 100644

--- a/chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc

+++ b/chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc

@@ -4,6 +4,7 @@

#include "chrome/common/extensions/api/extension_action/action_info.h"

#include "chrome/common/extensions/api/extension_action/script_badge_handler.h"

+#include "chrome/common/extensions/api/icons/icons_handler.h"

#include "chrome/common/extensions/extension_builder.h"

#include "chrome/common/extensions/extension_constants.h"

#include "chrome/common/extensions/extension_icon_set.h"

@@ -34,8 +35,11 @@ std::vector<InstallWarning> StripMissingFlagWarning(

class ScriptBadgeManifestTest : public ExtensionManifestTest {

protected:

virtual void SetUp() OVERRIDE {

+ ExtensionManifestTest::SetUp();

ManifestHandler::Register(extension_manifest_keys::kScriptBadge,

make_linked_ptr(new ScriptBadgeHandler));

+ ManifestHandler::Register(extension_manifest_keys::kIcons,

+ make_linked_ptr(new IconsHandler));

}

};