Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Side by Side Diff: chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc

Issue 11786003: Move Icons out of Extension class (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_browser_action
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/api/extension_action/action_info.h" 5 #include "chrome/common/extensions/api/extension_action/action_info.h"
6 #include "chrome/common/extensions/api/extension_action/script_badge_handler.h" 6 #include "chrome/common/extensions/api/extension_action/script_badge_handler.h"
7 #include "chrome/common/extensions/api/icons/icons_handler.h"
7 #include "chrome/common/extensions/extension_builder.h" 8 #include "chrome/common/extensions/extension_builder.h"
8 #include "chrome/common/extensions/extension_constants.h" 9 #include "chrome/common/extensions/extension_constants.h"
9 #include "chrome/common/extensions/extension_icon_set.h" 10 #include "chrome/common/extensions/extension_icon_set.h"
10 #include "chrome/common/extensions/extension_manifest_constants.h" 11 #include "chrome/common/extensions/extension_manifest_constants.h"
11 #include "chrome/common/extensions/feature_switch.h" 12 #include "chrome/common/extensions/feature_switch.h"
12 #include "chrome/common/extensions/manifest_handler.h" 13 #include "chrome/common/extensions/manifest_handler.h"
13 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 14 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
14 #include "extensions/common/install_warning.h" 15 #include "extensions/common/install_warning.h"
15 #include "testing/gmock/include/gmock/gmock.h" 16 #include "testing/gmock/include/gmock/gmock.h"
16 #include "testing/gtest/include/gtest/gtest.h" 17 #include "testing/gtest/include/gtest/gtest.h"
(...skipping 10 matching lines...) Expand all
27 for (size_t i = 0; i < install_warnings.size(); ++i) { 28 for (size_t i = 0; i < install_warnings.size(); ++i) {
28 if (install_warnings[i].message != errors::kScriptBadgeRequiresFlag) 29 if (install_warnings[i].message != errors::kScriptBadgeRequiresFlag)
29 result.push_back(install_warnings[i]); 30 result.push_back(install_warnings[i]);
30 } 31 }
31 return result; 32 return result;
32 } 33 }
33 34
34 class ScriptBadgeManifestTest : public ExtensionManifestTest { 35 class ScriptBadgeManifestTest : public ExtensionManifestTest {
35 protected: 36 protected:
36 virtual void SetUp() OVERRIDE { 37 virtual void SetUp() OVERRIDE {
38 ExtensionManifestTest::SetUp();
37 ManifestHandler::Register(extension_manifest_keys::kScriptBadge, 39 ManifestHandler::Register(extension_manifest_keys::kScriptBadge,
38 make_linked_ptr(new ScriptBadgeHandler)); 40 make_linked_ptr(new ScriptBadgeHandler));
41 ManifestHandler::Register(extension_manifest_keys::kIcons,
42 make_linked_ptr(new IconsHandler));
39 } 43 }
40 }; 44 };
41 45
42 } // namespace 46 } // namespace
43 47
44 TEST_F(ScriptBadgeManifestTest, ScriptBadgeBasic) { 48 TEST_F(ScriptBadgeManifestTest, ScriptBadgeBasic) {
45 scoped_refptr<Extension> extension( 49 scoped_refptr<Extension> extension(
46 ExtensionBuilder() 50 ExtensionBuilder()
47 .SetManifest(DictionaryBuilder() 51 .SetManifest(DictionaryBuilder()
48 .Set("manifest_version", 2) 52 .Set("manifest_version", 2)
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 EXPECT_EQ(2u, default_icon.map().size()); 151 EXPECT_EQ(2u, default_icon.map().size());
148 EXPECT_EQ("icon128.png", 152 EXPECT_EQ("icon128.png",
149 default_icon.Get(extension_misc::EXTENSION_ICON_BITTY, 153 default_icon.Get(extension_misc::EXTENSION_ICON_BITTY,
150 ExtensionIconSet::MATCH_EXACTLY)); 154 ExtensionIconSet::MATCH_EXACTLY));
151 EXPECT_EQ("icon128.png", 155 EXPECT_EQ("icon128.png",
152 default_icon.Get(2 * extension_misc::EXTENSION_ICON_BITTY, 156 default_icon.Get(2 * extension_misc::EXTENSION_ICON_BITTY,
153 ExtensionIconSet::MATCH_EXACTLY)); 157 ExtensionIconSet::MATCH_EXACTLY));
154 } 158 }
155 159
156 } // namespace extensions 160 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698