chrome/browser/ui/cocoa/location_bar/action_box_menu_bubble_controller.mm - Issue 11786003: Move Icons out of Extension class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/location_bar/action_box_menu_bubble_controller.mm

Issue 11786003: Move Icons out of Extension class (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_browser_action

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/infobars/extension_infobar_controller.mm ('k') | chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm » ('j') | chrome/common/extensions/api/extension_action/script_badge_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/location_bar/action_box_menu_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/location_bar/action_box_menu_bubble_controller.mm b/chrome/browser/ui/cocoa/location_bar/action_box_menu_bubble_controller.mm

index bfb87d125bc067932367aa020086156f8e81cf8e..69439edc543a96a1009fbea4f18d43fb5bf5ea98 100644

--- a/chrome/browser/ui/cocoa/location_bar/action_box_menu_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/location_bar/action_box_menu_bubble_controller.mm

@@ -15,6 +15,7 @@

#import "chrome/browser/ui/cocoa/info_bubble_window.h"

#include "chrome/browser/ui/toolbar/action_box_menu_model.h"

#include "chrome/common/extensions/api/extension_action/action_info.h"

+#include "chrome/common/extensions/api/icons/icons_handler.h"

#include "chrome/common/extensions/extension.h"

#include "chrome/common/extensions/extension_constants.h"

#include "grit/generated_resources.h"

@@ -66,7 +67,7 @@ class ExtensionIconLoaderBridge : public extensions::IconImage::Observer {

extension,

page_launcher_info->default_icon,

extension_misc::EXTENSION_ICON_ACTION,

- extensions::Extension::GetDefaultIcon(true),

+ extensions::IconsInfo::GetDefaultAppIcon(),

this));

OnExtensionIconImageChanged(icon_loader_.get());

}