Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: chrome/browser/ui/cocoa/location_bar/action_box_menu_bubble_controller.mm

Issue 11786003: Move Icons out of Extension class (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_browser_action
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/location_bar/action_box_menu_bubble_controller. h" 5 #import "chrome/browser/ui/cocoa/location_bar/action_box_menu_bubble_controller. h"
6 6
7 #include "base/mac/bundle_locations.h" 7 #include "base/mac/bundle_locations.h"
8 #include "base/mac/foundation_util.h" 8 #include "base/mac/foundation_util.h"
9 #include "base/mac/mac_util.h" 9 #include "base/mac/mac_util.h"
10 #include "base/sys_string_conversions.h" 10 #include "base/sys_string_conversions.h"
11 #include "chrome/browser/extensions/extension_icon_image.h" 11 #include "chrome/browser/extensions/extension_icon_image.h"
12 #import "chrome/browser/ui/cocoa/browser_window_utils.h" 12 #import "chrome/browser/ui/cocoa/browser_window_utils.h"
13 #import "chrome/browser/ui/cocoa/event_utils.h" 13 #import "chrome/browser/ui/cocoa/event_utils.h"
14 #import "chrome/browser/ui/cocoa/info_bubble_view.h" 14 #import "chrome/browser/ui/cocoa/info_bubble_view.h"
15 #import "chrome/browser/ui/cocoa/info_bubble_window.h" 15 #import "chrome/browser/ui/cocoa/info_bubble_window.h"
16 #include "chrome/browser/ui/toolbar/action_box_menu_model.h" 16 #include "chrome/browser/ui/toolbar/action_box_menu_model.h"
17 #include "chrome/common/extensions/api/extension_action/action_info.h" 17 #include "chrome/common/extensions/api/extension_action/action_info.h"
18 #include "chrome/common/extensions/api/icons/icons_handler.h"
18 #include "chrome/common/extensions/extension.h" 19 #include "chrome/common/extensions/extension.h"
19 #include "chrome/common/extensions/extension_constants.h" 20 #include "chrome/common/extensions/extension_constants.h"
20 #include "grit/generated_resources.h" 21 #include "grit/generated_resources.h"
21 #include "grit/theme_resources.h" 22 #include "grit/theme_resources.h"
22 #import "third_party/GTM/AppKit/GTMUILocalizerAndLayoutTweaker.h" 23 #import "third_party/GTM/AppKit/GTMUILocalizerAndLayoutTweaker.h"
23 #include "ui/base/resource/resource_bundle.h" 24 #include "ui/base/resource/resource_bundle.h"
24 #include "ui/gfx/image/image.h" 25 #include "ui/gfx/image/image.h"
25 #include "ui/gfx/image/image_skia_util_mac.h" 26 #include "ui/gfx/image/image_skia_util_mac.h"
26 27
27 @interface ActionBoxMenuBubbleController (Private) 28 @interface ActionBoxMenuBubbleController (Private)
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 ActionBoxMenuItemController* controller) 60 ActionBoxMenuItemController* controller)
60 : controller_(controller) { 61 : controller_(controller) {
61 const extensions::ActionInfo* page_launcher_info = 62 const extensions::ActionInfo* page_launcher_info =
62 extensions::ActionInfo::GetPageLauncherInfo(extension); 63 extensions::ActionInfo::GetPageLauncherInfo(extension);
63 DCHECK(page_launcher_info); 64 DCHECK(page_launcher_info);
64 icon_loader_.reset(new extensions::IconImage( 65 icon_loader_.reset(new extensions::IconImage(
65 profile, 66 profile,
66 extension, 67 extension,
67 page_launcher_info->default_icon, 68 page_launcher_info->default_icon,
68 extension_misc::EXTENSION_ICON_ACTION, 69 extension_misc::EXTENSION_ICON_ACTION,
69 extensions::Extension::GetDefaultIcon(true), 70 extensions::IconsInfo::GetDefaultAppIcon(),
70 this)); 71 this));
71 OnExtensionIconImageChanged(icon_loader_.get()); 72 OnExtensionIconImageChanged(icon_loader_.get());
72 } 73 }
73 74
74 private: 75 private:
75 virtual void OnExtensionIconImageChanged( 76 virtual void OnExtensionIconImageChanged(
76 extensions::IconImage* image) OVERRIDE { 77 extensions::IconImage* image) OVERRIDE {
77 [controller_ onExtensionIconImageChanged: 78 [controller_ onExtensionIconImageChanged:
78 gfx::NSImageFromImageSkia(image->image_skia())]; 79 gfx::NSImageFromImageSkia(image->image_skia())];
79 } 80 }
(...skipping 364 matching lines...) Expand 10 before | Expand all | Expand 10 after
444 - (void)accessibilityPerformAction:(NSString*)action { 445 - (void)accessibilityPerformAction:(NSString*)action {
445 if ([action isEqual:NSAccessibilityPressAction]) { 446 if ([action isEqual:NSAccessibilityPressAction]) {
446 [viewController_ itemSelected:self]; 447 [viewController_ itemSelected:self];
447 return; 448 return;
448 } 449 }
449 450
450 [super accessibilityPerformAction:action]; 451 [super accessibilityPerformAction:action];
451 } 452 }
452 453
453 @end 454 @end
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698