android_webview/native/aw_browser_dependency_factory.h - Issue 11785011: Remove incognito parameter from AwContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_browser_dependency_factory.h

Issue 11785011: Remove incognito parameter from AwContents (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebaselining findbugs, my fix removed a bug entry Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/native/aw_browser_dependency_factory.h

diff --git a/android_webview/native/aw_browser_dependency_factory.h b/android_webview/native/aw_browser_dependency_factory.h

index 87292d4c1e68d36e1aee46b34079a6abba4d15f2..f82348494be226eb474fd1eeb752a187998c8f08 100644

--- a/android_webview/native/aw_browser_dependency_factory.h

+++ b/android_webview/native/aw_browser_dependency_factory.h

@@ -37,10 +37,10 @@ class AwBrowserDependencyFactory {

static AwBrowserDependencyFactory* GetInstance();

// Returns the current browser context based on the specified mode.

- virtual content::BrowserContext* GetBrowserContext(bool incognito) = 0;

+ virtual content::BrowserContext* GetBrowserContext() = 0;

// Constructs and returns ownership of a WebContents instance.

- virtual content::WebContents* CreateWebContents(bool incognito) = 0;

+ virtual content::WebContents* CreateWebContents() = 0;

protected:

AwBrowserDependencyFactory();