Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2335)

Unified Diff: android_webview/lib/aw_browser_dependency_factory_impl.cc

Issue 11785011: Remove incognito parameter from AwContents (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebaselining findbugs, my fix removed a bug entry Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/lib/aw_browser_dependency_factory_impl.cc
diff --git a/android_webview/lib/aw_browser_dependency_factory_impl.cc b/android_webview/lib/aw_browser_dependency_factory_impl.cc
index c1dd34589b8cde0da350e28f6708e650abc5b043..bcff32f00bf6eaefdf28d43ebffaa39c0cd6a3aa 100644
--- a/android_webview/lib/aw_browser_dependency_factory_impl.cc
+++ b/android_webview/lib/aw_browser_dependency_factory_impl.cc
@@ -21,8 +21,7 @@ base::LazyInstance<AwBrowserDependencyFactoryImpl>::Leaky g_lazy_instance;
} // namespace
-AwBrowserDependencyFactoryImpl::AwBrowserDependencyFactoryImpl() {
-}
+AwBrowserDependencyFactoryImpl::AwBrowserDependencyFactoryImpl() {}
AwBrowserDependencyFactoryImpl::~AwBrowserDependencyFactoryImpl() {}
@@ -31,18 +30,14 @@ void AwBrowserDependencyFactoryImpl::InstallInstance() {
SetInstance(g_lazy_instance.Pointer());
}
-content::BrowserContext* AwBrowserDependencyFactoryImpl::GetBrowserContext(
- bool incognito) {
- // TODO(boliu): Remove incognito parameter.
- LOG_IF(ERROR, incognito) << "Android WebView does not support incognito mode"
- << " yet. Creating normal profile instead.";
+content::BrowserContext* AwBrowserDependencyFactoryImpl::GetBrowserContext() {
return static_cast<AwContentBrowserClient*>(
content::GetContentClient()->browser())->GetAwBrowserContext();
}
-WebContents* AwBrowserDependencyFactoryImpl::CreateWebContents(bool incognito) {
+WebContents* AwBrowserDependencyFactoryImpl::CreateWebContents() {
return content::WebContents::Create(
- content::WebContents::CreateParams(GetBrowserContext(incognito)));
+ content::WebContents::CreateParams(GetBrowserContext()));
}
} // namespace android_webview
« no previous file with comments | « android_webview/lib/aw_browser_dependency_factory_impl.h ('k') | android_webview/native/aw_browser_dependency_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698