Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Unified Diff: ash/wm/ash_activation_controller_unittest.cc

Issue 11783018: Fix crash and failures in ash_unittests with the new focus controller by disabling launcher activat… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/launcher/launcher_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/ash_activation_controller_unittest.cc
===================================================================
--- ash/wm/ash_activation_controller_unittest.cc (revision 175345)
+++ ash/wm/ash_activation_controller_unittest.cc (working copy)
@@ -11,6 +11,7 @@
#include "ash/wm/property_util.h"
#include "ash/wm/window_util.h"
#include "ui/aura/window.h"
+#include "ui/views/corewm/corewm_switches.h"
namespace ash {
@@ -90,6 +91,10 @@
}
TEST_F(AshActivationControllerTest, LauncherEndToEndFallbackOnDestroyTest) {
+ // TODO(mtomasz): make this test work with the FocusController.
+ if (views::corewm::UseFocusController())
+ return;
+
// This test checks the whole fallback activation flow.
SetSpokenFeedbackState(true);
@@ -105,6 +110,10 @@
}
TEST_F(AshActivationControllerTest, LauncherEndToEndFallbackOnMinimizeTest) {
+ // TODO(mtomasz): make this test work with the FocusController.
+ if (views::corewm::UseFocusController())
+ return;
+
// This test checks the whole fallback activation flow.
SetSpokenFeedbackState(true);
« no previous file with comments | « ash/launcher/launcher_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698