Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 11781007: Added a test to ensure that stack frames are reported correctly when an exception is thrown in a ch… (Closed)

Created:
7 years, 11 months ago by siva
Modified:
7 years, 11 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Added a test to ensure that stack frames are reported correctly when an exception is thrown in a chain which has inlined methods. This test currently fails and I have added an issue 7757 for it and skipped it in the status file. Committed: https://code.google.com/p/dart/source/detail?r=16778

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -0 lines) Patch
A tests/vm/dart/inline_stack_frame_test.dart View 1 1 chunk +74 lines, -0 lines 2 comments Download
M tests/vm/vm.status View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
siva
7 years, 11 months ago (2013-01-08 01:09:53 UTC) #1
Ivan Posva
Have you verified that dart2js and dart2dart provide the stack trace information that you are ...
7 years, 11 months ago (2013-01-08 01:15:04 UTC) #2
siva
I have verified dart2js. All tests under runtime/tests/vm are skipped for dart2dart per the status ...
7 years, 11 months ago (2013-01-08 01:22:12 UTC) #3
Florian Schneider
https://chromiumcodereview.appspot.com/11781007/diff/4001/tests/vm/dart/inline_stack_frame_test.dart File tests/vm/dart/inline_stack_frame_test.dart (right): https://chromiumcodereview.appspot.com/11781007/diff/4001/tests/vm/dart/inline_stack_frame_test.dart#newcode14 tests/vm/dart/inline_stack_frame_test.dart:14: // func2 and func1 are not getting inlined and ...
7 years, 11 months ago (2013-01-08 09:31:37 UTC) #4
siva
https://chromiumcodereview.appspot.com/11781007/diff/4001/tests/vm/dart/inline_stack_frame_test.dart File tests/vm/dart/inline_stack_frame_test.dart (right): https://chromiumcodereview.appspot.com/11781007/diff/4001/tests/vm/dart/inline_stack_frame_test.dart#newcode14 tests/vm/dart/inline_stack_frame_test.dart:14: // func2 and func1 are not getting inlined and ...
7 years, 11 months ago (2013-01-08 18:06:46 UTC) #5
srdjan
7 years, 11 months ago (2013-01-08 18:41:15 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698