Issue 11779045: Have WebMediaPlayerImpl maintain a reference to AudioRendererSink.

Issue 11779045: Have WebMediaPlayerImpl maintain a reference to AudioRendererSink. (Closed)

Created:
7 years, 11 months ago by scherkus (not reviewing)

Modified:
7 years, 11 months ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
chromium-reviews, feature-media-reviews_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Have WebMediaPlayerImpl maintain a reference to AudioRendererSink. BUG=168768 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175765

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	webkit/media/webmediaplayer_impl.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
	M	webkit/media/webmediaplayer_impl.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 7 (0 generated)

acolwell GONE FROM CHROMIUM

LGTM The ownership/lifetime here should really be fixed soon. This current situation is very brittle.

7 years, 11 months ago (2013-01-08 20:00:29 UTC) #2

scherkus (not reviewing)

On 2013/01/08 20:00:29, acolwell wrote: > LGTM > > The ownership/lifetime here should really be ...

7 years, 11 months ago (2013-01-08 20:21:39 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/11779045/1

7 years, 11 months ago (2013-01-08 20:22:06 UTC) #4

commit-bot: I haz the power

Retried try job too often on win_aura for step(s) content_browsertests

7 years, 11 months ago (2013-01-09 04:53:58 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/11779045/1

7 years, 11 months ago (2013-01-09 07:55:14 UTC) #6

Message was sent while issue was closed.

Change committed as 175765