Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Unified Diff: webkit/media/webmediaplayer_impl.h

Issue 11779045: Have WebMediaPlayerImpl maintain a reference to AudioRendererSink. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webkit/media/webmediaplayer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/media/webmediaplayer_impl.h
diff --git a/webkit/media/webmediaplayer_impl.h b/webkit/media/webmediaplayer_impl.h
index 16fba65035d34efe61f637c45ef7d15387c15cd4..e9f8cd57c35fc1a303179c646f35f4f59f21e0bc 100644
--- a/webkit/media/webmediaplayer_impl.h
+++ b/webkit/media/webmediaplayer_impl.h
@@ -325,7 +325,13 @@ class WebMediaPlayerImpl
bool incremented_externally_allocated_memory_;
+ // TODO(scherkus): Sadly these two objects are the same and we're also forced
+ // to maintain an additional reference to |audio_renderer_sink_| otherwise
+ // |audio_source_provider_| will go bad after |pipeline_| shuts down.
+ //
+ // See http://crbug.com/136442 for details.
WebKit::WebAudioSourceProvider* audio_source_provider_;
+ scoped_refptr<media::AudioRendererSink> audio_renderer_sink_;
bool is_local_source_;
bool supports_save_;
« no previous file with comments | « no previous file | webkit/media/webmediaplayer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698