Issue 11778100: Telemetry: Add tests which would've caught the memory_benchmark breakage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11778100: Telemetry: Add tests which would've caught the memory_benchmark breakage. (Closed)

Created:
7 years, 11 months ago by marja

Modified:
7 years, 11 months ago

Reviewers:
nduca

CC:
chromium-reviews, chrome-speed-team+watch_google.com, pam+watch_chromium.org, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Telemetry: Add tests which would've caught the memory_benchmark breakage. BUG=169084 R=nduca NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176143

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -0 lines)			Patch
	M	tools/telemetry/telemetry/csv_page_benchmark_results_unittest.py	View		1 chunk	+23 lines, -0 lines	0 comments	Download
	M	tools/telemetry/telemetry/page_benchmark_results_unittest.py	View		1 chunk	+29 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

nduca

LGTM. Dont forget to also have a very simplistic test for memory benchmark. See the ...

7 years, 11 months ago (2013-01-10 20:10:18 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/11778100/1

7 years, 11 months ago (2013-01-10 20:23:06 UTC) #3

Message was sent while issue was closed.

Change committed as 176143