Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: tools/telemetry/telemetry/csv_page_benchmark_results_unittest.py

Issue 11778100: Telemetry: Add tests which would've caught the memory_benchmark breakage. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page_benchmark_results_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/csv_page_benchmark_results_unittest.py
diff --git a/tools/telemetry/telemetry/csv_page_benchmark_results_unittest.py b/tools/telemetry/telemetry/csv_page_benchmark_results_unittest.py
index db57b3520e4bbbad1aed07153744634a0cd394e0..f18807d1e5b2cbf1f4268a137ff5a0488c8bb220 100644
--- a/tools/telemetry/telemetry/csv_page_benchmark_results_unittest.py
+++ b/tools/telemetry/telemetry/csv_page_benchmark_results_unittest.py
@@ -103,4 +103,27 @@ class CsvPageBenchmarkResultsTest(unittest.TestCase):
[[self._page_set[0].url, '-', '3'],
[self._page_set[1].url, '4', '-']])
+ def test_histogram(self):
+ results = NonPrintingCsvPageBenchmarkResults(csv.writer(self._output),
+ False)
+ results.WillMeasurePage(self._page_set[0])
+ results.Add('a', '',
+ '{"buckets": [{"low": 1, "high": 2, "count": 1}]}',
+ data_type='histogram')
+ results.DidMeasurePage()
+
+ results.WillMeasurePage(self._page_set[1])
+ results.Add('a', '',
+ '{"buckets": [{"low": 2, "high": 3, "count": 1}]}',
+ data_type='histogram')
+ results.DidMeasurePage()
+ results.PrintSummary('tag')
+
+ self.assertEquals(
+ self.output_header_row,
+ ['url', 'a ()'])
+ self.assertEquals(
+ self.output_data_rows,
+ [[self._page_set[0].url, '1.5'],
+ [self._page_set[1].url, '2.5']])
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page_benchmark_results_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698