Issue 11778080: Fix member variable order in WebGestureCurve implementations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11778080: Fix member variable order in WebGestureCurve implementations (Closed)

Created:
7 years, 11 months ago by jamesr

Modified:
7 years, 11 months ago

Reviewers:
tony

CC:
chromium-reviews, darin-cc_chromium.org, rjkroege

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix member variable order in WebGestureCurve implementations The call to scrollBy() can result in the curve going away, so it's unsafe to touch member variables after making the call. Covered by webkit_unit_tests. BUG=169156 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176037

Patch Set 1 #

Patch Set 2 : fix typo in fling_animator_impl_android #

Patch Set 3 : add comments #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
webkit/glue/fling_animator_impl_android.cc	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
webkit/glue/touch_fling_gesture_curve.cc	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
webkit/support/web_gesture_curve_mock.cc	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/11778080/8001

7 years, 11 months ago (2013-01-10 01:17:58 UTC) #4

Message was sent while issue was closed.

Change committed as 176037

Expand Messages | Collapse Messages