Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: webkit/glue/touch_fling_gesture_curve.cc

Issue 11778080: Fix member variable order in WebGestureCurve implementations (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add comments Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/fling_animator_impl_android.cc ('k') | webkit/support/web_gesture_curve_mock.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/touch_fling_gesture_curve.cc
diff --git a/webkit/glue/touch_fling_gesture_curve.cc b/webkit/glue/touch_fling_gesture_curve.cc
index d33a6894aa8965d3696d4f50791dc9b0083f1139..523500db1cc7085b10941835a07b3d57f03bdbb9 100644
--- a/webkit/glue/touch_fling_gesture_curve.cc
+++ b/webkit/glue/touch_fling_gesture_curve.cc
@@ -165,6 +165,8 @@ bool TouchFlingGestureCurve::apply(double time, WebGestureCurveTarget* target) {
cumulative_scroll_ = WebSize(scroll.x, scroll.y);
if (time + time_offset_ < curve_duration_ || scroll_increment != WebPoint()) {
+ // scrollBy() could delete this curve if the animation is over, so don't
+ // touch any member variables after making that call.
target->scrollBy(scroll_increment);
return true;
}
« no previous file with comments | « webkit/glue/fling_animator_impl_android.cc ('k') | webkit/support/web_gesture_curve_mock.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698