Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: chrome/browser/ui/web_applications/web_app_ui.cc

Issue 11777009: Remove redundant |errored| member from IconHostMsg_DidDownloadFavicon (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/web_applications/web_app_ui.cc
diff --git a/chrome/browser/ui/web_applications/web_app_ui.cc b/chrome/browser/ui/web_applications/web_app_ui.cc
index abfd9b463ec2707eee2cfd115253762ec4751881..e9e47434924093c6139e0883081be640cc82984b 100644
--- a/chrome/browser/ui/web_applications/web_app_ui.cc
+++ b/chrome/browser/ui/web_applications/web_app_ui.cc
@@ -65,7 +65,6 @@ class UpdateShortcutWorker : public content::NotificationObserver {
void DidDownloadFavicon(
int id,
const GURL& image_url,
- bool errored,
int requested_size,
const std::vector<SkBitmap>& bitmaps);
@@ -168,7 +167,6 @@ void UpdateShortcutWorker::DownloadIcon() {
void UpdateShortcutWorker::DidDownloadFavicon(
int id,
const GURL& image_url,
- bool errored,
int requested_size,
const std::vector<SkBitmap>& bitmaps) {
std::vector<ui::ScaleFactor> scale_factors;
@@ -179,7 +177,7 @@ void UpdateShortcutWorker::DidDownloadFavicon(
scale_factors,
requested_size);
- if (!errored && !bitmaps.empty() && !bitmaps[closest_index].isNull()) {
+ if (!bitmaps.empty() && !bitmaps[closest_index].isNull()) {
// Update icon with download image and update shortcut.
shortcut_info_.favicon = gfx::Image(bitmaps[closest_index]);
extensions::TabHelper* extensions_tab_helper =
« no previous file with comments | « chrome/browser/ui/views/create_application_shortcut_view.cc ('k') | content/browser/web_contents/web_contents_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698