Stop writing logs to %ProgramData%\Chromoting\debug.log (Windows only).

Stop writing logs to %ProgramData%\Chromoting\debug.log (Windows only).

%ProgramData% is read-only for processes running at low integrity level. since the host is now running at low integrity level and logs are written to ETW, this CL quits using debug.log altogether. See http://code.google.com/p/sawbuck/wiki/HowToCaptureLogsOffline for an example how logs can be collected via ETW infrastructure. The Chromoting provider's guid is "{2db51ca1-4fd8-4b88-b5a2-fb8606b66b02}".

BUG=134694
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175433

[alexeypa (please no reviews), 2013-01-07 18:25:12]

PTAL.

[Jamie, 2013-01-07 18:31:21]

https://chromiumcodereview.appspot.com/11776029/diff/1/remoting/host/logging_...
File remoting/host/logging_win.cc (left):

https://chromiumcodereview.appspot.com/11776029/diff/1/remoting/host/logging_...
remoting/host/logging_win.cc:40: #endif  // !defined(NDEBUG)
This disables logging entirely for debug builds, correct? Couldn't we instead
log with best-effort to, for example, C:\TEMP? That would save each developer
adding logging to their local checkouts to help with debugging--we'd just need
to create the directory instead.

[alexeypa (please no reviews), 2013-01-07 19:10:30]

https://chromiumcodereview.appspot.com/11776029/diff/1/remoting/host/logging_...
File remoting/host/logging_win.cc (left):

https://chromiumcodereview.appspot.com/11776029/diff/1/remoting/host/logging_...
remoting/host/logging_win.cc:40: #endif  // !defined(NDEBUG)
On 2013/01/07 18:31:21, Jamie wrote:
> This disables logging entirely for debug builds, correct? 

This disables logging to a file. Logging to ETW isn't going anywhere. 

> Couldn't we instead
> log with best-effort to, for example, C:\TEMP? That would save each developer
> adding logging to their local checkouts to help with debugging--we'd just need
> to create the directory instead.

I don't think it is a good idea. First, all sorts of temp folders are not
accessible to low integrity processes as well. At least their parent folders are
not accessible to low integrity processes. There is a special AppData\LocalLow
but it is not going to be any more convenient to use than ETW.

[Jamie, 2013-01-07 19:28:11]

lgtm

[commit-bot: I haz the power, 2013-01-07 19:31:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexeypa@chromium.org/11776029/1

[commit-bot: I haz the power, 2013-01-07 21:59:12]

Retried try job too often on win_aura for step(s) interactive_ui_tests

[commit-bot: I haz the power, 2013-01-07 22:33:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexeypa@chromium.org/11776029/1

[commit-bot: I haz the power, 2013-01-08 00:41:46]

Change committed as 175433