Stop writing logs to %ProgramData%\Chromoting\debug.log (Windows only).

remoting/host/logging_win.cc

Index: remoting/host/logging_win.cc
diff --git a/remoting/host/logging_win.cc b/remoting/host/logging_win.cc
index 0ab6f597ecdf5d6e51f0edccc7501f2dbd9ca946..fa4b7ab95c570133b51518e4aaaa84208f8cf677 100644
--- a/remoting/host/logging_win.cc
+++ b/remoting/host/logging_win.cc
@@ -6,10 +6,8 @@
 
 #include <guiddef.h>
 
-#include "base/file_path.h"
 #include "base/logging.h"
 #include "base/logging_win.h"
-#include "remoting/host/branding.h"
 
 // {2db51ca1-4fd8-4b88-b5a2-fb8606b66b02}
 const GUID kRemotingHostLogProvider =
@@ -19,25 +17,13 @@ const GUID kRemotingHostLogProvider =
 namespace remoting {
 
 void InitHostLogging() {
-#if defined(NDEBUG)
-  // Write logs to the system debug log in release build.
+  // Write logs to the system debug log.
   logging::InitLogging(
       NULL,
       logging::LOG_ONLY_TO_SYSTEM_DEBUG_LOG,
-      logging::LOCK_LOG_FILE,
+      logging::DONT_LOCK_LOG_FILE,
       logging::DELETE_OLD_LOG_FILE,
       logging::DISABLE_DCHECK_FOR_NON_OFFICIAL_RELEASE_BUILDS);
-#else  // !defined(NDEBUG)
-  // Write logs to a file in debug build.
-  FilePath debug_log = remoting::GetConfigDir().
-      Append(FILE_PATH_LITERAL("debug.log"));
-  logging::InitLogging(
-      debug_log.value().c_str(),
-      logging::LOG_ONLY_TO_FILE,
-      logging::LOCK_LOG_FILE,
-      logging::DELETE_OLD_LOG_FILE,
-      logging::DISABLE_DCHECK_FOR_NON_OFFICIAL_RELEASE_BUILDS);
-#endif  // !defined(NDEBUG)

[Jamie, 2013/01/07 18:31:21]

This disables logging entirely for debug builds, correct? Couldn't we instead
log with best-effort to, for example, C:\TEMP? That would save each developer
adding logging to their local checkouts to help with debugging--we'd just need
to create the directory instead.

[alexeypa (please no reviews), 2013/01/07 19:10:31]

This disables logging to a file. Logging to ETW isn't going anywhere. 
I don't think it is a good idea. First, all sorts of temp folders are not
accessible to low integrity processes as well. At least their parent folders are
not accessible to low integrity processes. There is a special AppData\LocalLow
but it is not going to be any more convenient to use than ETW.

 
   // Enable trace control and transport through event tracing for Windows.
   logging::LogEventProvider::Initialize(kRemotingHostLogProvider);