Issue 11774006: A pub package to host dart.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11774006: A pub package to host dart.js (Closed)

Created:
7 years, 11 months ago by vsm

Modified:
7 years, 11 months ago

Reviewers:
devoncarew, dgrove

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Create an sdk package to host dart.js Devon: I think we'd need corresponding editor changes. The editor could use either pub or just replace the path (as mentioned in the bug). BUG=6723 Committed: https://code.google.com/p/dart/source/detail?r=16812

Patch Set 1 #

Patch Set 2 : Fix test suite to use new path #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -14 lines)			Patch
A +	pkg/browser/lib/dart.js	View		1 chunk	+0 lines, -13 lines	0 comments	Download
A	pkg/browser/pubspec.yaml	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

devoncarew

7 years, 11 months ago (2013-01-08 17:43:01 UTC) #3

lgtm

Looks good - we should be able to turn around the editor changes today.

Expand Messages | Collapse Messages