Allow embedders to provide a custom view for popup (select box) widgets,

Allow embedders to provide a custom view for popup (select box) widgets,
the same way they have the ability to provide a custom view for page widgets.
All the widget views are created using WebContentsView, which can be
overriden by embedders with ContentBrowserClient::OverrideCreateWebContentsView
Contributed by rosca@adobe.com

BUG=155761
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176092

[rosca, 2013-01-08 13:38:38]

Please review,

Thanks,
Ion.

[Avi (use Gerrit), 2013-01-08 16:46:47]

https://codereview.chromium.org/11773042/diff/1/content/browser/web_contents/...
File content/browser/web_contents/web_contents_view_android.cc (right):

https://codereview.chromium.org/11773042/diff/1/content/browser/web_contents/...
content/browser/web_contents/web_contents_view_android.cc:85: return
RenderWidgetHostViewPort::CreateViewForWidget(render_widget_host);
In this and other platform files, why doesn't

return CreateViewForWidget(render_widget_host);

work? Why do you need to specify the routing of the call through the
RenderWidgetHostViewPort interface?

[rosca, 2013-01-08 19:34:29]

https://codereview.chromium.org/11773042/diff/1/content/browser/web_contents/...
File content/browser/web_contents/web_contents_view_android.cc (right):

https://codereview.chromium.org/11773042/diff/1/content/browser/web_contents/...
content/browser/web_contents/web_contents_view_android.cc:85: return
RenderWidgetHostViewPort::CreateViewForWidget(render_widget_host);
On 2013/01/08 16:46:47, Avi wrote:
> In this and other platform files, why doesn't
> 
> return CreateViewForWidget(render_widget_host);
> 
> work? Why do you need to specify the routing of the call through the
> RenderWidgetHostViewPort interface?

RenderWidgetHostView[Port]::CreateViewForWidget is the static creator for
platform specific RenderWidgetHostView*. 

WebContentsView::CreateViewForWidget is part of content API and it is used for
creating the main web page for curent web contents, its implementation usually
includes (besides widget creation) some web page specific initialisations and it
changes the WebContentsView's state with newly created web page. This is more
obvious in the win/mac implementation of WebContentsView::CreateViewForWidget.

WebContentsView[Platform]::CreateViewForWidget (for other platforms than
android) also uses RenderWidgetHostView[Port]::CreateViewForWidget to create
widget for the main web page.

[Avi (use Gerrit), 2013-01-08 20:51:15]

OK, this looks reasonable, lgtm. Jói, what do you think?

https://codereview.chromium.org/11773042/diff/1/content/browser/web_contents/...
File content/browser/web_contents/web_contents_view_android.cc (right):

https://codereview.chromium.org/11773042/diff/1/content/browser/web_contents/...
content/browser/web_contents/web_contents_view_android.cc:85: return
RenderWidgetHostViewPort::CreateViewForWidget(render_widget_host);
OK, gotcha.

[Jói, 2013-01-09 00:13:57]

+jam

This seems fine to me but I think John should review.

Cheers,
Jói

[jam, 2013-01-09 17:01:09]

https://codereview.chromium.org/11773042/diff/1/AUTHORS
File AUTHORS (right):

https://codereview.chromium.org/11773042/diff/1/AUTHORS#newcode218
AUTHORS:218: Ion Rosca <rosca@adobe.com>
see
http://dev.chromium.org/developers/contributing-code/external-contributor-che...

you need to sign the CLA before adding your name here

[Jói, 2013-01-09 17:02:56]

https://codereview.chromium.org/11773042/diff/1/AUTHORS
File AUTHORS (right):

https://codereview.chromium.org/11773042/diff/1/AUTHORS#newcode218
AUTHORS:218: Ion Rosca <rosca@adobe.com>
On 2013/01/09 17:01:10, John Abd-El-Malek wrote:
> see
>
http://dev.chromium.org/developers/contributing-code/external-contributor-che...
> 
> you need to sign the CLA before adding your name here

FYI, I checked and rosca@adobe.com is already on the corporate CLA list for
Adobe.

[jam, 2013-01-09 19:06:39]

On 2013/01/09 17:02:56, Jói wrote:
> https://codereview.chromium.org/11773042/diff/1/AUTHORS
> File AUTHORS (right):
> 
> https://codereview.chromium.org/11773042/diff/1/AUTHORS#newcode218
> AUTHORS:218: Ion Rosca <mailto:rosca@adobe.com>
> On 2013/01/09 17:01:10, John Abd-El-Malek wrote:
> > see
> >
>
http://dev.chromium.org/developers/contributing-code/external-contributor-che...
> > 
> > you need to sign the CLA before adding your name here
> 
> FYI, I checked and mailto:rosca@adobe.com is already on the corporate CLA list
for
> Adobe.

ah, you're right. i must have searched initially before the document started
loading

lgtm

[commit-bot: I haz the power, 2013-01-09 19:16:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rosca@adobe.com/11773042/1

[commit-bot: I haz the power, 2013-01-09 19:16:13]

Failed to apply patch for AUTHORS:
While running patch -p0 --forward --force --no-backup-if-mismatch;
  patching file AUTHORS
  Hunk #1 FAILED at 215.
  1 out of 1 hunk FAILED -- saving rejects to file AUTHORS.rej

Patch:       AUTHORS
Index: AUTHORS
===================================================================
--- AUTHORS	(revision 175506)
+++ AUTHORS	(working copy)
@@ -215,3 +215,4 @@
 Martin Bednorz <m.s.bednorz@gmail.com>
 Kamil Jiwa <kamil.jiwa@gmail.com>
 Keene Pan <keenepan@linpus.com>
+Ion Rosca <rosca@adobe.com>

[commit-bot: I haz the power, 2013-01-10 09:22:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rosca@adobe.com/11773042/13002

[commit-bot: I haz the power, 2013-01-10 10:08:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rosca@adobe.com/11773042/25006

[commit-bot: I haz the power, 2013-01-10 11:45:38]

Retried try job too often on win_aura for step(s) content_browsertests

[commit-bot: I haz the power, 2013-01-10 13:52:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rosca@adobe.com/11773042/25006

[commit-bot: I haz the power, 2013-01-10 15:37:21]

Change committed as 176092